Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config/jobs/*/eks: disable S3 log uploads, add conformance tests #10121

Merged
merged 3 commits into from
Nov 20, 2018
Merged

config/jobs/*/eks: disable S3 log uploads, add conformance tests #10121

merged 3 commits into from
Nov 20, 2018

Conversation

gyuho
Copy link
Member

@gyuho gyuho commented Nov 9, 2018

Now basic e2e tests are working (thanks SIG testing team!) We'd like to add another test to run conformance. And disable log S3 uploads, which was enabled for initial debugging purposes. Changing the test run period from 1h to 2h. And also using EKS vendored kubectl for now; it was getting token errors, which I am still debugging around.

ref. #9814

/cc @BenTheElder @krzyzacy

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/testgrid size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 9, 2018
@gyuho
Copy link
Member Author

gyuho commented Nov 9, 2018

/hold

Found kubectl operations are failing due to kubeconfig misconfiguration. Debugging.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2018
@gyuho
Copy link
Member Author

gyuho commented Nov 9, 2018

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2018
@krzyzacy
Copy link
Member

krzyzacy commented Nov 9, 2018

/lint

k8s-ci-robot
k8s-ci-robot reviewed Nov 9, 2018
View reviewed changes
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krzyzacy: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BenTheElder
BenTheElder approved these changes Nov 12, 2018
View reviewed changes
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 12, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b7d8a8c56f1eafa964ac9beb1274ee0f7b4858c6

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 12, 2018
@gyuho
config/jobs: disalbe S3 log uploads, add conformance tests
dfa1aa6 
Now basic e2e tests are working (thanks SIG testing team!)
We'd like to add another test to run conformance.
And disable log S3 uploads, which was enabled for initial debugging
purposes.

Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
kubetest/eks: move "aws-iam-authenticator" download code to "aws-k8s-…
85fa5f0 
…tester"

Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
vendor: upgrade "aws-k8s-tester" to 0.1.3
5ce9af5 
Signed-off-by: Gyuho Lee <[email protected]>
@gyuho
Copy link
Member Author

gyuho commented Nov 16, 2018

/lint

k8s-ci-robot
k8s-ci-robot reviewed Nov 16, 2018
View reviewed changes
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gyuho: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gyuho
Copy link
Member Author

gyuho commented Nov 19, 2018

@BenTheElder @krzyzacy Kindly ping. Thanks!

@krzyzacy
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 19, 2018
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5320c80a12ad40c11fe70d03a91bf081095a4ae8

@gyuho
Copy link
Member Author

gyuho commented Nov 20, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, gyuho, krzyzacy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [BenTheElder,krzyzacy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gyuho
Copy link
Member Author

gyuho commented Nov 20, 2018

@BenTheElder @krzyzacy Can I also get /approve? :)

@krzyzacy
Copy link
Member

you already have approve label, it didn't merge because you have a do-not-merge/hold

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6410647 into kubernetes:master Nov 20, 2018
@k8s-ci-robot
Copy link
Contributor

@gyuho: Updated the job-config configmap using the following files:

  • key k8s-aws-eks-1.10.yaml using file config/jobs/kubernetes/sig-aws/eks/k8s-aws-eks-1.10.yaml

In response to this:

Now basic e2e tests are working (thanks SIG testing team!) We'd like to add another test to run conformance. And disable log S3 uploads, which was enabled for initial debugging purposes. Changing the test run period from 1h to 2h. And also using EKS vendored kubectl for now; it was getting token errors, which I am still debugging around.

ref. #9814

/cc @BenTheElder @krzyzacy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gyuho gyuho deleted the eks-conformance branch November 20, 2018 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k8s-ci-robot k8s-ci-robot k8s-ci-robot left review comments

@BenTheElder BenTheElder BenTheElder approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

Assignees

@BenTheElder BenTheElder

@krzyzacy krzyzacy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/testgrid cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gyuho @krzyzacy @k8s-ci-robot @BenTheElder