Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick bot failing with pushToNamedFork is not implemented in the v2 client #30937

Closed
killianmuldoon opened this issue Oct 4, 2023 · 10 comments · Fixed by #30971 or #30981
Closed
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.

Comments

@killianmuldoon
Copy link
Contributor

What happened:
k8s-infra-cherrypick-robot is failing to do cherry-picks with the error failed to push cherry-picked changes in GitHub: pushToNamedFork is not implemented in the v2 client

An example of this error occurring is

What you expected to happen:
Cherry-pick PR to be opened against correct branch

How to reproduce it (as minimally and precisely as possible):
Comment the /cherry-pick release-1.8 on PR https://github.com/kubernetes-sigs/cluster-api-provider-vsphere
/pull/2397

Please provide links to example occurrences, if any:
https://github.com/kubernetes-sigs/cluster-api-provider-vsphere
/pull/2397#issuecomment-1746652732
Anything else we need to know?:

@killianmuldoon killianmuldoon added the kind/bug Categorizes issue or PR as related to a bug. label Oct 4, 2023
@k8s-ci-robot
Copy link
Contributor

There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

  • /sig <group-name>
  • /wg <group-name>
  • /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Oct 4, 2023
@chrischdi
Copy link
Member

Maybe related to #30924

@ArangoGutierrez
Copy link
Contributor

/cc

@killianmuldoon
Copy link
Contributor Author

@cjwagner just in case you have some idea if that change could have this impact.

@marquiz
Copy link
Contributor

marquiz commented Oct 5, 2023

/cc

@cjwagner
Copy link
Member

cjwagner commented Oct 5, 2023

Yeah that PR is definitely the cause of this. I didn't realize there was an unimplemented method in the v2 client. I'll push a fix ASAP (by tomorrow).

@andyzhangx
Copy link
Member

this is not fixed yet, I could still get the same error.

@andyzhangx
Copy link
Member

/reopen

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cjwagner
Copy link
Member

cjwagner commented Oct 9, 2023

The code should be fixed, it just needs to be deployed: #30981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
7 participants