-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-alpha features from job ci-kubernetes-e2e-gci-gce-alpha-features #23642
Comments
/sig api-machinery |
Additionally, we could try to onboard jobs listed on kubernetes/kubernetes#104556 |
/priority backlog |
/help This might require some discussion, but the required changes are relatively easy. |
@mmiranda96: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hey @mmiranda96 I am totally new here. Can I pick this up? Will look into what all is required and come up with questions. |
Sure @rayandas, feel free to take it and ask anything. Thanks! |
@mmiranda96 Thanks. |
/assign |
Hi @mmiranda96 I took a good look on this issue today. For the below task, is there is there a list of features that should be tested by these jobs?
|
That's correct @rayandas. The main part of this task is removing the features from the test arg As for the alpha features, it would make sense to do the following:
/sig release For now, I'd recommend only removing non-alpha features. Once we get an input from the release team, we can decide which new alpha features to include. A helpful note: both jobs run the same set of tests. However, |
Sure @mmiranda96. I will raise a PR for now after removing non-alpha features. |
Quick update on this: it makes sense to add all features listed as Alpha (and belonging to SIG Node) in the 1.23 KEP tracker. Do you want to take this @jnbhavya? Let me know if you have any questions on how to implement this. It looks like the job is passing now, @yuzhiquan (Testgrid). Was it failing in a particular change? It might be related to the change itself. |
This change success firstly, but after an rebase, it's failed, would you like to give some review on pr kubernetes/kubernetes#102162? @mmiranda96 |
Emm, i did nothing but ci successd, thanks @mmiranda96 |
@mmiranda96 sure i can |
/assign |
@mmiranda96 I need to add alpha feature in |
That's right @jnbhavya. I would recommend searching under test/e2e_node which tags should be included. |
/assign |
Sure @mmiranda96. I raised a PR for add alpha features in pull-kubernetes-e2e-gce-alpha-features job. |
@mmiranda96 Hey can you please look into it? |
Apologies, I missed it last week. I've replied in the PR, please take a look. |
@mmiranda96 can you please give lgtm again |
@mmiranda96 is that PR merge after testing ? |
@jainbhavya65 I've added the suggested approver, as I'm only a member and cannot grant approve to PRs. Also, please let's keep the conversation on the PR. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What should be cleaned up or changed:
Jobs
ci-kubernetes-e2e-gci-gce-alpha-features
andpull-kubernetes-e2e-gce-alpha-features
run for several features which are no longer in alpha status. Cleaning up the features requires:Provide any links for context:
Here are all the features tested by both jobs, together with its status and KEP link:
The text was updated successfully, but these errors were encountered: