Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-alpha features from job ci-kubernetes-e2e-gci-gce-alpha-features #23642

Closed
mmiranda96 opened this issue Sep 16, 2021 · 36 comments · Fixed by #23845
Closed

Remove non-alpha features from job ci-kubernetes-e2e-gci-gce-alpha-features #23642

mmiranda96 opened this issue Sep 16, 2021 · 36 comments · Fixed by #23845
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@mmiranda96
Copy link
Contributor

What should be cleaned up or changed:
Jobs ci-kubernetes-e2e-gci-gce-alpha-features and pull-kubernetes-e2e-gce-alpha-features run for several features which are no longer in alpha status. Cleaning up the features requires:

  1. Updating the job configurations to no longer focus non-alpha features.
  2. (Optional, up to discussion) Adding new alpha features which should be tested by these jobs.
  3. Ensuring the job is running properly.

Provide any links for context:
Here are all the features tested by both jobs, together with its status and KEP link:

Feature Status KEP Link
ServiceAccountIssuerDiscovery Stable kubernetes/enhancements#1393
StorageVersionAPI Alpha https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/2330-migrating-api-objects-to-latest-storage-version
Audit Stable kubernetes/enhancements#22
PodPreset Alpha kubernetes/enhancements#162
RunAsGroup Stable kubernetes/enhancements#213
TTLAfterFinished Stable kubernetes/enhancements#592
NodeLease Stable kubernetes/enhancements#589
CSIStorageCapacity Beta kubernetes/enhancements#1472
GenericEphemeralVolume Stable kubernetes/enhancements#1698
DaemonSetUpdateSurge Beta kubernetes/enhancements#1591
CrossNamespacePodAffinity Beta kubernetes/enhancements#2249
@mmiranda96 mmiranda96 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 16, 2021
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Sep 16, 2021
@mmiranda96
Copy link
Contributor Author

/sig api-machinery
/sig apps
/sig auth
/sig node
/sig scheduling
/sig service-catalog
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 16, 2021
@mmiranda96
Copy link
Contributor Author

Additionally, we could try to onboard jobs listed on kubernetes/kubernetes#104556

@mmiranda96
Copy link
Contributor Author

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Sep 16, 2021
@mmiranda96
Copy link
Contributor Author

/help
/good-first-issue

This might require some discussion, but the required changes are relatively easy.

@k8s-ci-robot
Copy link
Contributor

@mmiranda96:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue

This might require some discussion, but the required changes are relatively easy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 20, 2021
@rayandas
Copy link
Member

rayandas commented Sep 22, 2021

Hey @mmiranda96 I am totally new here. Can I pick this up? Will look into what all is required and come up with questions.

@mmiranda96
Copy link
Contributor Author

Sure @rayandas, feel free to take it and ask anything. Thanks!

@rayandas
Copy link
Member

@mmiranda96 Thanks.

@rayandas
Copy link
Member

/assign

@rayandas
Copy link
Member

Hi @mmiranda96 I took a good look on this issue today.
So as part of the cleanup, we have to remove non-alpha features which are in test_args from both ci-kubernetes-e2e-gci-gce-alpha-features and pull-kubernetes-e2e-gce-alpha-features jobs right?

For the below task, is there is there a list of features that should be tested by these jobs?

Adding new alpha features which should be tested by these jobs.

@mmiranda96
Copy link
Contributor Author

That's correct @rayandas. The main part of this task is removing the features from the test arg ginkgo.focus.

As for the alpha features, it would make sense to do the following:

  1. Retrieve all features that are in alpha status. For this, you can access 1.23 enhacement tracking (for context on this, I found this tracker on the homepage of kubernetes/enhacements).
  2. From those alpha features, filter the ones that make sense to be tested in this job. I'm not entirely sure what's the best approach here. I'm adding sig-release, since these jobs are owned by the release team.

/sig release

For now, I'd recommend only removing non-alpha features. Once we get an input from the release team, we can decide which new alpha features to include.

A helpful note: both jobs run the same set of tests. However, ci-kubernetes-e2e-gci-gce-alpha-features runs as a periodic job, while pull-kubernetes-e2e-gce-alpha-features runs as a presubmit job.

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Sep 29, 2021
@rayandas
Copy link
Member

rayandas commented Sep 30, 2021

Sure @mmiranda96. I will raise a PR for now after removing non-alpha features.
For the rest of the task, I will first try to retrieve all the features that are in alpha and wait for release team's input.

@yuzhiquan
Copy link
Member

Quick update on this: it makes sense to add all features listed as Alpha (and belonging to SIG Node) in the 1.23 KEP tracker. Do you want to take this @jnbhavya? Let me know if you have any questions on how to implement this.
It looks like the job is passing now, @yuzhiquan (Testgrid). Was it failing in a particular change? It might be related to the change itself.

This change success firstly, but after an rebase, it's failed, would you like to give some review on pr kubernetes/kubernetes#102162? @mmiranda96

Emm, i did nothing but ci successd, thanks @mmiranda96

@jnbhavya
Copy link

@mmiranda96 sure i can

@jnbhavya
Copy link

/assign

@jnbhavya
Copy link

jnbhavya commented Oct 28, 2021

@mmiranda96 I need to add alpha feature in ginkgo.focus. am i right? which are left out

@mmiranda96
Copy link
Contributor Author

That's right @jnbhavya. I would recommend searching under test/e2e_node which tags should be included.

@jainbhavya65
Copy link

/assign

@jainbhavya65
Copy link

jainbhavya65 commented Nov 5, 2021

Sure @mmiranda96. I raised a PR for add alpha features in pull-kubernetes-e2e-gce-alpha-features job.
Please look into it if any changes required let me know thanks.

@jainbhavya65
Copy link

@mmiranda96 Hey can you please look into it?

@rayandas rayandas removed their assignment Nov 9, 2021
@mmiranda96
Copy link
Contributor Author

Apologies, I missed it last week. I've replied in the PR, please take a look.

@jainbhavya65
Copy link

@mmiranda96 can you please give lgtm again

@jainbhavya65
Copy link

jainbhavya65 commented Nov 10, 2021

@mmiranda96 is that PR merge after testing ?

@mmiranda96
Copy link
Contributor Author

@jainbhavya65 I've added the suggested approver, as I'm only a member and cannot grant approve to PRs. Also, please let's keep the conversation on the PR.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/service-catalog Categorizes an issue or PR as relevant to SIG Service Catalog. sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
Archived in project
7 participants