Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate merge-blocking jobs to dedicated cluster: pull-kubernetes-e2e-kind #18812

Closed
spiffxp opened this issue Aug 13, 2020 · 11 comments
Closed
Assignees
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.

Comments

@spiffxp
Copy link
Member

spiffxp commented Aug 13, 2020

Part of #18550

This is a trial balloon of a specific type of job (kind)

I'd like to get a sense of what sort of scaling jobs of this type are going to cause k8s-infra-prow-build. I'd also like to see whether this interferes with existing release-blocking job load. If so, we should consider a more boilerplate-filled approach of setting up a separate nodepool, and using taints/tolerations/nodeselectors for merge-blocking vs. release-blocking jobs.

I'm choosing pull-kubernetes-e2e-kind because I've seen it hit scheduling errors due to lack of resources lately. Getting it over to k8s-infra-prow-build will allow more community visibility, and ideally more resources thanks to autoscaling.

/area jobs
/wg k8s-infra
/sig testing
/sig release

@k8s-ci-robot k8s-ci-robot added area/jobs wg/k8s-infra sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 13, 2020
@spiffxp
Copy link
Member Author

spiffxp commented Aug 13, 2020

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 13, 2020
ameukam added a commit to ameukam/test-infra that referenced this issue Aug 13, 2020
Migrate pull-kubernetes-e2e-kind to give more visibility to community
about resources consumption.

Ref: kubernetes#18812

Signed-off-by: Arnaud Meukam <[email protected]>
@spiffxp
Copy link
Member Author

spiffxp commented Aug 13, 2020

/assign

@spiffxp
Copy link
Member Author

spiffxp commented Aug 13, 2020

/assign @ameukam
who opened #18817

@spiffxp
Copy link
Member Author

spiffxp commented Aug 14, 2020

https://prow.k8s.io/?job=pull-kubernetes-e2e-kind&state=error - so there's a bunch of jobs that errored between 10am and 12pm PT... which lines up roughly with the time between the two PR's merging

I'm guessing cpu: 7400m was too much to ask for on k8s-infra-prow-build nodes, and then switching to cpu: 4 made the jobs schedulable again.

@spiffxp
Copy link
Member Author

spiffxp commented Aug 14, 2020

I'm reasonably happy with this

Screen Shot 2020-08-14 at 8 27 14 AM

@BenTheElder
Copy link
Member

follow up: disable the network policy addon in the cluster

@ameukam
Copy link
Member

ameukam commented Aug 25, 2020

@spiffxp Is there still something else to do? I think we can close.

@BenTheElder Out of curiosity, what's the reason behind this action :

disable the network policy addon in the cluster

@spiffxp
Copy link
Member Author

spiffxp commented Aug 28, 2020

what's the reason behind this action

We are not, as far as I know, actually doing anything with it? Maybe it would be better to get the resources back

@spiffxp
Copy link
Member Author

spiffxp commented Aug 29, 2020

/close
Calling this done, it continued to behave well once opened up traffic to v1.20 PRs

@k8s-ci-robot
Copy link
Contributor

@spiffxp: Closing this issue.

In response to this:

/close
Calling this done, it continued to behave well once opened up traffic to v1.20 PRs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/jobs kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Development

No branches or pull requests

4 participants