Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Release: update team process documentation #782

Merged
merged 2 commits into from
Sep 13, 2019

Conversation

tpepper
Copy link
Member

@tpepper tpepper commented Sep 11, 2019

Add description of how we are working together as a team now to track the evolving state of cherry pick PRs and arrive at consensus on whether or not to approve each for merge.

We've shifted from a set of managers for individual patch releases to a
combined, collaborative Patch Release Team.  Update docs to match.

Signed-off-by: Tim Pepper <[email protected]>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 11, 2019
@tpepper
Copy link
Member Author

tpepper commented Sep 11, 2019

@kubernetes/patch-release-team FYI

Also this should represent closure on #369

@tpepper
Copy link
Member Author

tpepper commented Sep 11, 2019

GitHub doesn't enable concise tracking of the evolving state of PRs
as they shuffle along towards meeting merge criteria on a branch.
During the past 9 months we've evolved a process for this in the
patch release team so we can collaborate on triaging inbound cherry
picks and driving consensus on whether to accept them on a branch.
This new documentation attempts to capture the current process.  It
reads a lot more complicated than it is, although better tooling
would nevertheless be very welcome.

Signed-off-by: Tim Pepper <[email protected]>
Copy link
Member

@idealhack idealhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this looks clear to me. I have two questions which are not blocking.

patch release. Within each of these sections, cherry picks are
listed in reverse PR number order, newest on top. To add a notation
for a newly inbound cherry pick, add a row above the current newest
row.
Copy link
Member

@idealhack idealhack Sep 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how often do patch release team members enter or modify new items?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends. I guess less often, after we cut a patch, more often just before we cut a patch. I think I had times where I did check on cherry pick PR only once a week and I had times where I checked and updated cherry pick PRs more then once a day. Not sure how other's on the team handle that though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Over in kubernetes/community#4081 I note we scrub things about weekly, but more often just before release.

### Future Work

* It would be awesome to replace this manual stateful review workflow with a
tool. Such a tool appears to need invented.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are some features or specs for such a tool? if it's needed very much, let's start to think about it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No spec exists, but automation in support of the manual inspect, triage, share thoughts, discuss, form consensus would be useful. As I write that...It almost sounds like Gerrit. /me ducks from the thrown tomatoes.

@hoegaarden
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hoegaarden, tpepper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit beca4ae into kubernetes:master Sep 13, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants