Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update release notes draft to version v1.31.0-alpha.2 #2542

Closed
wants to merge 1 commit into from
Closed

Update release notes draft to version v1.31.0-alpha.2 #2542

wants to merge 1 commit into from

Conversation

satyampsoni
Copy link
Member

What type of PR is this?
/kind documentation

What this PR does / why we need it:
This PR updates the Release Notes Draft to k/k v1.31.0-alpha.2

Which issue(s) this PR fixes:

Special notes for your reviewer:
This is an automated PR generated from krel The Kubernetes Release Toolbox

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-team Issues or PRs related to the release-team subproject needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jun 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 25, 2024
shecodesmagic
shecodesmagic reviewed Jun 25, 2024
View reviewed changes
releases/release-1.31/release-notes/maps/pr-124075-map.yaml
Comment on lines +3 to +4
text: 'DRA: client-side validation of a ResourceHandle would have accepted a missing
DriverName, whereas server-side validation then would have raised an error.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this explaining a bug fix?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does DRA stand for? Dynamic Resource Allocation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is a bug fix. Maybe we can add "fix" and define DRA here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the full form

shecodesmagic
shecodesmagic reviewed Jun 25, 2024
View reviewed changes
releases/release-1.31/release-notes/maps/pr-124131-map.yaml
@@ -0,0 +1,4 @@
pr: 124131
releasenote:
text: Endpointslices mirrored from Endpoints by the EndpointSliceMirroring controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a bug fix? if so, how about changing it to:
Fixed the bug where if Endpointslices mirrored from Endpoints by the EndpointSliceMirroring controller they would not reconcile if modified.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's do it.

npolshakova
npolshakova reviewed Jun 29, 2024
View reviewed changes
releases/release-1.31/release-notes/maps/pr-123669-map.yaml Outdated
@@ -0,0 +1,3 @@
pr: 123668
Copy link
Contributor

@npolshakova npolshakova Jun 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so strange... the PR is actually kubernetes/kubernetes#123669

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can this be possible?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway I am editing it to 123669 as of now

@npolshakova npolshakova mentioned this pull request Jul 2, 2024
Closed
@satyampsoni satyampsoni closed this Jul 2, 2024
@satyampsoni satyampsoni force-pushed the release-notes-draft-v1.31.0-alpha.2 branch from 9b4e17f to e38eb10 Compare July 2, 2024 17:20
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Jul 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: satyampsoni
Once this PR has been reviewed and has the lgtm label, please assign jeremyrickard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@npolshakova npolshakova mentioned this pull request Jul 2, 2024
Merged
@npolshakova npolshakova mentioned this pull request Aug 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shecodesmagic shecodesmagic shecodesmagic left review comments

@rayandas rayandas rayandas left review comments

@npolshakova npolshakova npolshakova left review comments

@cloudmelon cloudmelon cloudmelon left review comments

@sreeram-venkitesh sreeram-venkitesh Awaiting requested review from sreeram-venkitesh

Assignees
No one assigned
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@satyampsoni @k8s-ci-robot @cloudmelon @npolshakova @rayandas @shecodesmagic