Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified PRR freeze and exceptions.yaml in enhancements handbook #2518

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Clarified PRR freeze and exceptions.yaml in enhancements handbook #2518

merged 8 commits into from
Sep 5, 2024

Conversation

sreeram-venkitesh
Copy link
Member

What type of PR is this:

/kind documentation

What this PR does / why we need it:

This PR fixes two issues from #2375

  • Clarifying what PRR freeze in the enhancements handbook and updating the communication template for the enhancements freeze.
  • Adding instruction to create the exceptions.yaml file after the release, along with an example.

Which issue(s) this PR fixes:

Fixes part of #2375

Special notes for your reviewer:

CC: @Priyankasaggu11929 @npolshakova

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-team Issues or PRs related to the release-team subproject labels Jun 3, 2024
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2024
Priyankasaggu11929
Priyankasaggu11929 reviewed Jun 4, 2024
View reviewed changes
release-team/role-handbooks/enhancements/README.md
@@ -177,6 +177,8 @@ It is important that this process be followed and documentation remain up-to-dat
- Send an email to [Kubernetes-Dev](https://groups.google.com/a/kubernetes.io/g/dev) that Enhancement freeze is coming and share current Enhancements status. Examples [1](https://groups.google.com/g/kubernetes-dev/c/-nTNtBBHL2Y/m/WfNzb_E1EAAJ).
- Provide updates during release team meetings
- Use the `KEPs by Stage` insight from the Enhancement Tracking Board ([example](https://github.com/orgs/kubernetes/projects/98/insights/3))
- Notify folks in [#prod-readiness](https://kubernetes.slack.com/archives/CPNHUMN74) about KEPs waiting for PRR reviews with the project board filtered for KEPs missing PRR assignees.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, pretty useful!

@Priyankasaggu11929
Copy link
Member

@sreeram-venkitesh, outside of this PR's scope, but a note:

we should add the blurb about PRR freeze in this document too - https://github.com/kubernetes/sig-release/blob/master/releases/release_phases.md

@Priyankasaggu11929
Copy link
Member

cc: @salehsedghpour

@Priyankasaggu11929 Priyankasaggu11929 added this to the v1.31 milestone Jun 4, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 4, 2024
Priyankasaggu11929
Priyankasaggu11929 requested changes Jun 4, 2024
View reviewed changes
releases/release_phases.md Outdated Show resolved Hide resolved
@Priyankasaggu11929
Copy link
Member

@sreeram-venkitesh, could you please squash the commits also to two (one for each file change). Thanks!

@sreeram-venkitesh sreeram-venkitesh force-pushed the clarify-prr-freeze-in-enhancements-handbook branch from d78ee59 to 6a2cba2 Compare June 4, 2024 16:03
@sreeram-venkitesh
Copy link
Member Author

@Priyankasaggu11929 I've squashed the commits into two, one for each file! PTAL!

@sreeram-venkitesh sreeram-venkitesh force-pushed the clarify-prr-freeze-in-enhancements-handbook branch from 610f94d to d9120b3 Compare June 4, 2024 17:06
@sreeram-venkitesh
Copy link
Member Author

@npolshakova I've made the changes, PTAL!

@ArkaSaha30 ArkaSaha30 mentioned this pull request Jun 5, 2024
Open
12 tasks
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 10, 2024
@Priyankasaggu11929
Copy link
Member

@sreeram-venkitesh, just checking if it is ready for another round of review? 🙂

@sreeram-venkitesh
Copy link
Member Author

@Priyankasaggu11929 Yes please!

@Priyankasaggu11929
Copy link
Member

@tjons @ArkaSaha30 @dipesh-rawat @mickeyboxell @prianna

could you all please give a round of review, so we get it merged max by end of this week? Thanks!

tjons
tjons reviewed Aug 12, 2024
View reviewed changes
Copy link
Contributor

@tjons tjons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me! Couple questions and I agree with @Priyankasaggu11929's feedback - thanks for doing this @sreeram-venkitesh!

release-team/role-handbooks/enhancements/README.md Outdated Show resolved Hide resolved
release-team/role-handbooks/enhancements/README.md Show resolved Hide resolved
@sreeram-venkitesh
Copy link
Member Author

@Priyankasaggu11929 @tjons Please review the new changes! I want to get this merged before the next cycle starts!

@Priyankasaggu11929
Copy link
Member

Other than my comment here #2518 (comment), rest LGTM!

Thank you so much again for all the work, @sreeram-venkitesh.

@Priyankasaggu11929
Copy link
Member

/lgtm
/approve

/hold
unhold if ready to merge!

Thanks again, @sreeram-venkitesh 🙂

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 27, 2024
@sreeram-venkitesh
Copy link
Member Author

Thanks a lot! Will unhold once @tjons also confirms the changes from his end :)

tjons
tjons approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@tjons tjons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Priyankasaggu11929, sreeram-venkitesh, tjons

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sreeram-venkitesh
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit df390ef into kubernetes:master Sep 5, 2024
2 checks passed
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.31, v1.32 Sep 5, 2024
@sreeram-venkitesh sreeram-venkitesh mentioned this pull request Nov 1, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Priyankasaggu11929 Priyankasaggu11929 Priyankasaggu11929 requested changes

@npolshakova npolshakova npolshakova left review comments

@prianna prianna prianna left review comments

@tjons tjons tjons approved these changes

@Atharva-Shinde Atharva-Shinde Awaiting requested review from Atharva-Shinde

@marosset marosset Awaiting requested review from marosset

Assignees

@tjons tjons

@Priyankasaggu11929 Priyankasaggu11929

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.32
Development

Successfully merging this pull request may close these issues.
6 participants
@sreeram-venkitesh @Priyankasaggu11929 @k8s-ci-robot @prianna @tjons @npolshakova