-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release notes draft v1.20.0 rc.0 #1371
Release notes draft v1.20.0 rc.0 #1371
Conversation
./krel release-notes --create-draft-pr --fix --fork wilsonehusin --repo /home/wilson/workspace/go/src/k8s.io/kubernetes --tag v1.20.0-rc.0
Editing through krel is too inefficient since I already have the PR numbers directly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, great work :)
Thanks @wilsonehusin 🎉
/approve |
/assign @palnabarun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
err I'm gonna assume that myself haven't approved this and let morning-me do the approval /hold |
Great job @wilsonehusin It also looks good to me 👍 |
@@ -396,24 +493,39 @@ | |||
|
|||
### Other (Cleanup or Flake) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're removing the documentation for the cloud-controller-manager skeleton binary (which doesn't actually integrate with any provider).
SIG API Machinery, is that correct? Slack discussion starts at https://kubernetes.slack.com/archives/C0EG7JC6T/p1606929363248600
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to follow the conversation -- thanks for flagging Tim!
### Runtime log sanitation | ||
Logs can now be configured to use runtime protection from leaking sensitive data. [Details for this experimental feature is available in documentation](https://docs.k8s.io/concepts/cluster-administration/system-logs/#log-sanitization). | ||
|
||
### Pod resource metrics | ||
On-demand metrics calculation is now available through `/metrics/resources`. [When enabled]( | ||
https://docs.k8s.io/concepts/cluster-administration/system-metrics#kube-scheduler-metrics), the endpoint will report the requested resources and the desired limits of all running pods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SIG Instrumentation notes LGTM.
Since doc changes aren't live yet, links for reference:
Co-authored-by: Elana Hashman <[email protected]>
For more information about kubectl debug, see Debugging Running Pods on the Kubernetes website, kubectl help debug, or reach out to SIG CLI by visiting #sig-cli or commenting on [enhancement #1441](https://features.k8s.io/1441). | ||
|
||
### Removing deprecated flags in kubeadm | ||
`kubeadm` removes a significant number of deprecated flags in this release. The complete list of flags are available below on Urgent Upgrade Notes section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'd reword this section to something in the lines of the following:
### Deprecations and deprecated feature removals in kubeadm
`kubeadm` applies a number of deprecations and removals of deprecated features in this release. More details are available in the Urgent Upgrade Notes and Kind / Deprecation sections.
rationale:
- the most important deprecation is the "master" label/taint.
- the deprecations and removals are spread across a couple of different sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me, thanks for reviewing @neolit123!
The release note for kubernetes/kubernetes#92743 should be hoisted to the "before upgrade" section. I just updated the release note text in that PR to include a link to a tool that can be run prior to upgrade to identify existing objects with invalid references.
|
Co-authored-by: Sergey Kanzhelev <[email protected]>
|
||
[Documentation](https://docs.k8s.io/docs/home) | ||
# Changelog since v1.19.0 | ||
|
||
## What's New (Major Themes) | ||
|
||
### Dockershim deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi @wilsonehusin – when these eventually make their way over to k/website
, each of these headers will need a full line underneath them, or the header rendering will break:
### Dockershim deprecation | |
### Dockershim deprecation | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😭 okay I'll get on it, thanks Celeste!
### go1.15.2 | ||
|
||
go1.15.2 has been integrated to Kubernets project as of this release, [including other infrastructure related updates on this effort](https://github.com/kubernetes/kubernetes/pull/94449). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wilsonehusin The 1.20.0 release will be built with Go 1.15.5 (ref: kubernetes/kubernetes#95776). I'm not sure is the migration fully-done yet, but should we mention go1.15.2 or go1.15.5 here?
cc @justaugustus -- maybe you have some input on this. 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm updating it as 1.15.5 per kubernetes/release#1651 (checkboxes for 1.15.5 are all ✅ )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for bringing it up @xmudrii!
kubernetes/kubernetes#95776 has been merged kubernetes/release#1651 checklist of 1.15.5 is all done
alright thank you so much everyone for the cooperation! /hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ehashman, puerco, saschagrunert, soniasingla, wilsonehusin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Great job @wilsonehusin . Thank you very much !! |
What type of PR is this:
/kind documentation
What this PR does / why we need it:
Release notes for Kubernetes 1.20, based on
v1.20.0-rc.0
tagWhich issue(s) this PR fixes:
None
Special notes for your reviewer:
I will go through this again tomorrow with the community documentation guide in hand, too tired now and just want to get this out first 😄
/cc @celestehorgan @tanjacky @soniasingla @JamesLaverack @puerco