packaging.md: point to new location. #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we moved this document to be versioned with the tooling since it is mostly a user guide.
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
area/release-eng
k8s-ci-robot
added
the
lgtm
justaugustus
requested changes
Jul 24, 2020
There was a problem hiding this comment.
@BenTheElder -- Two things:
- Can we add a tombstone date (ref: https://github.com/kubernetes/community/blob/master/contributors/guide/style-guide.md#moving-a-document)
- Can you sweep any references in this repo and point them to the new location?
|
ACK, I'll do this tomorrow.
…On Thu, Jul 23, 2020 at 10:48 PM Stephen Augustus ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@BenTheElder <https://github.com/BenTheElder> -- Two things:
1. Can we add a tombstone date (ref:
https://github.com/kubernetes/community/blob/master/contributors/guide/style-guide.md#moving-a-document
)
2. Can you sweep any references in this repo and point them to the new
location?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1160 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHADK6NRO7FMG7CXNTLHEDR5EOBLANCNFSM4PGLXRWQ>
.
|
|
/lgtm Let's take anything remaining as a follow-up. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, hasheddan, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we moved this document to be versioned with the tooling since it is mostly a user guide.
What type of PR is this:
/kind cleanup
What this PR does / why we need it:
follow up to kubernetes/release#1435
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: