Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.19: Update release cycle timelines (pre-KubeCon release) #1065

Merged
merged 1 commit into from
Apr 24, 2020
Merged

1.19: Update release cycle timelines (pre-KubeCon release) #1065

merged 1 commit into from
Apr 24, 2020

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Apr 23, 2020 •
edited
Loading

What type of PR is this:

/kind cleanup documentation

What this PR does / why we need it:

This is an alternative pre-KubeCon release schedule (compared to #1058).

  • Move Enhancements Freeze to week 6 (was week 4)

  • Move Code Freeze to week 11 (was week 9)

    Deviation from SIG Release meeting:
    We give an extra week in the dev cycle to shorten Code Freeze to 6 weeks.
    Several comments on the previous proposal said that Code Freeze was too long.

  • RCs get released on a biweekly cadence (week 11, 13, 15)

  • Move Cherry Pick Deadline to week 16 (was week 11)

  • Move 1.19.0 release date to week 17 (was week 12)

    This is the week before KubeCon.

  • Move retro to week 19 (was week 12)

    This is the week after KubeCon.

  • Push Docs deadlines

  • Add a Test Freeze milestone to coincide with Cherry Pick deadline

    From @spiffxp on previous review:
    "Specific request from SIG Arch conformance: typically code freeze is
    the date by which no new conformance tests are accepted, so as not to
    disrupt CI Signal and force them to chase the stability of a moving
    target. Can we get a test freeze date later in the cycle, to allow
    addition of new tests beforehand, but force fixing/reverting tests
    afterward for CI Signal stability?"

Signed-off-by: Stephen Augustus [email protected]

/assign @tpepper @onlydole
cc: @kubernetes/release-team-leads @kubernetes/release-team

Special notes for your reviewer:

Lazy consensus timeout set for Friday, April 24, 5pm US ET.
/hold

Week comparison across release cycles:

1.16 1.17 1.18 1.19 (current) 1.19 (revised - pre-KubeCon)
Release Start 1 1 1 1 1
Enhancements Freeze 5 4 4 4 6
Code Freeze 9 8 9 9 11
Docs Complete 11 9 11 11 13
Cherry Pick Deadline 11 11 11 11 16
Release 12 12 12 12 17
Retrospective 12 12 12 12 19

@justaugustus
1.19: Update release cycle timelines (pre-KubeCon release)
058949e 
- Move Enhancements Freeze to week 6 (was week 4)
- Move Code Freeze to week 11 (was week 9)
- RCs get released on a biweekly cadence (week 11, 13, 15)
- Move Cherry Pick Deadline to week 16 (was week 11)
- Move 1.19.0 release date to week 17 (was week 12)
- Move retro to week 19 (was week 12)
- Push Docs deadlines
- Add a Test Freeze milestone to coincide with Cherry Pick deadline

  From spiffxp on review:
  "Specific request from SIG Arch conformance: typically code freeze is
  the date by which no new conformance tests are accepted, so as not to
  disrupt CI Signal and force them to chase the stability of a moving
  target. Can we get a test freeze date later in the cycle, to allow
  addition of new tests beforehand, but force fixing/reverting tests
  afterward for CI Signal stability?"

Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2020
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 23, 2020
@k8s-ci-robot k8s-ci-robot added area/release-team Issues or PRs related to the release-team subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2020
@onlydole
Copy link
Member

image

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2020
@justaugustus justaugustus added this to the v1.19 milestone Apr 23, 2020
@jeremyrickard
Copy link
Contributor

/lgtm

@justaugustus justaugustus mentioned this pull request Apr 23, 2020
Closed
@markjacksonfishing
Copy link
Contributor

Love it!
image

savitharaghunathan
savitharaghunathan approved these changes Apr 23, 2020
View reviewed changes
Copy link
Member

@savitharaghunathan savitharaghunathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tpepper
Copy link
Member

tpepper commented Apr 23, 2020

/lgtm
/approve

@palnabarun
Copy link
Member

/lgtm

@justaugustus
Copy link
Member Author

Email sent to k-dev & k-sig-leads: https://groups.google.com/d/msg/kubernetes-dev/IVpiIOZ4WcM/I_LGDpNkAgAJ

Lazy consensus timeout remains the same: Friday, April 24, 5pm US ET

cc-ing previous reviewers:
@liggitt @enj @johnbelamaric @dims @spiffxp @lavalamp @jberkus

@justaugustus justaugustus added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Apr 24, 2020
@mkorbi
Copy link
Contributor

mkorbi commented Apr 24, 2020

/lgtm

@enj
Copy link
Member

enj commented Apr 24, 2020

/lgtm

saschagrunert
saschagrunert approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

cpanato
cpanato approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

gianarb
gianarb approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@gianarb gianarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

hasheddan
hasheddan approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@saschagrunert saschagrunert mentioned this pull request Apr 24, 2020
Closed
@johnbelamaric
Copy link
Member

I am OK with this.

/lgtm

@lavalamp
Copy link
Member

I still think 6 weeks of code freeze is extreme, but it is better than 11, and I guess I'll take what I can get...

@puerco
Copy link
Member

puerco commented Apr 24, 2020

/lgtm

2 similar comments
@spiffxp
Copy link
Member

spiffxp commented Apr 24, 2020

/lgtm

@liggitt
Copy link
Member

liggitt commented Apr 24, 2020

/lgtm

xmudrii
xmudrii approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, enj, gianarb, hasheddan, jeremyrickard, johnbelamaric, justaugustus, liggitt, mkorbi, onlydole, palnabarun, puerco, saschagrunert, savitharaghunathan, spiffxp, tpepper, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

Hearing no objections to this updated proposal and having hit the lazy consensus timeout, I think we're good to merge here.

Thanks everyone for the feedback!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit cecbdb4 into kubernetes:master Apr 24, 2020
@justaugustus justaugustus mentioned this pull request May 9, 2020
Merged
@justaugustus justaugustus mentioned this pull request Jun 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasheddan hasheddan hasheddan approved these changes

@xmudrii xmudrii xmudrii approved these changes

@savitharaghunathan savitharaghunathan savitharaghunathan approved these changes

@cpanato cpanato cpanato approved these changes

@gianarb gianarb gianarb approved these changes

@saschagrunert saschagrunert saschagrunert approved these changes

@mkorbi mkorbi Awaiting requested review from mkorbi

Assignees

@onlydole onlydole

@saschagrunert saschagrunert

@gianarb gianarb

@tpepper tpepper

@cpanato cpanato

@savitharaghunathan savitharaghunathan

@enj enj

@palnabarun palnabarun

@mkorbi mkorbi

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-team Issues or PRs related to the release-team subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.