Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

short image url broken the world peace #2146

Closed
willzhang opened this issue Jan 18, 2023 · 5 comments
Closed

short image url broken the world peace #2146

willzhang opened this issue Jan 18, 2023 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@willzhang
Copy link

willzhang commented Jan 18, 2023

What would you like to be added:

format1: <registry_url>/<image_name>:<image_tag>

format2: <registry_url>/<project_name>/<image_name>:<image_tag>

everyone use long format image url in the world(docker.io quay.io ghcr.io) ,but only this five image use short format image url ,who controlr this action and why?

root@node51:~# kubeadm config images list
I0117 09:21:50.999039 1387839 version.go:256] remote version is much newer: v1.26.0; falling back to: stable-1.25
registry.k8s.io/kube-apiserver:v1.25.5
registry.k8s.io/kube-controller-manager:v1.25.5
registry.k8s.io/kube-scheduler:v1.25.5
registry.k8s.io/kube-proxy:v1.25.5
registry.k8s.io/pause:3.8
registry.k8s.io/etcd:3.5.6-0
registry.k8s.io/coredns/coredns:v1.9.3

Why is this needed:

1、This leads to the need for special processing of these special images during image distribution, resulting in various kinds of confusion。
2、harbor not support format1, But Harbor is widely used in production environment

suggestion

release k8s core component image for this format:

registry.k8s.io/kubernetes/pause:3.7
registry.k8s.io/kubernetes/kube-apiserver:v1.25.5
registry.k8s.io/kubernetes/kube-controller-manager:v1.25.5
registry.k8s.io/kubernetes/kube-scheduler:v1.25.5
registry.k8s.io/kubernetes/kube-proxy:v1.25.5

related1: kubernetes/registry.k8s.io#139

@willzhang willzhang added kind/feature Categorizes issue or PR as related to a new feature. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jan 18, 2023
@saschagrunert
Copy link
Member

saschagrunert commented Jan 18, 2023

@willzhang we already promote images two both locations, with and without the /kubernetes prefix. For example both URLs point to the same image:

> podman pull registry.k8s.io/kubernetes/kube-apiserver:v1.26.0
…
a31e1d84401e66c2f4162d70fdbd7db2a43d34f85785911c9cd57402a3d8e761

> podman pull registry.k8s.io/kube-apiserver:v1.26.0
…
a31e1d84401e66c2f4162d70fdbd7db2a43d34f85785911c9cd57402a3d8e761

Those are the images in the kubernetes namespace:
https://console.cloud.google.com/gcr/images/k8s-artifacts-prod/us/kubernetes?project=k8s-artifacts-prod

@willzhang
Copy link
Author

but as default ,kubeadm not use this url, can let kubeadm use this url as default?

@neolit123
Copy link
Member

neolit123 commented Jan 19, 2023

but as default ,kubeadm not use this url, can let kubeadm use this url as default

we technically can, but as i mentioned before it would take a long time and needs a good plan

you can log a k/kubeadm issue about it, but i don't think we can handle it soon.

@saschagrunert
Copy link
Member

Alright, looks like we're already set from a release perspective and have to handle it in kubeadm.
/close

@k8s-ci-robot
Copy link
Contributor

@saschagrunert: Closing this issue.

In response to this:

Alright, looks like we're already set from a release perspective and have to handle it in kubeadm.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. needs-priority sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

No branches or pull requests

4 participants