-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused changelog-update
script
#983
Remove unused changelog-update
script
#983
Conversation
@saschagrunert: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saschagrunert -- Hound comes back with no significant entries: https://cs.k8s.io/?q=changelog-update&i=nope&files=&repos=, so I'm in favor of cleaning up!
Can you remove the listing for changelog-update
in the README.md
?
The `changelog-update` is not used inside this repository, because its main functionality is part of `anago` and `relnotes`. Signed-off-by: Sascha Grunert <[email protected]>
Yes, I changed the README.md as well |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The
changelog-update
is not used inside this repository, because its main functionality is part ofanago
andrelnotes
.This might be a dangerous change since I'm not sure if we have other repositories depending on this script. 😇 On the other hand I'm pretty sure that this is the code part which has been put into anago some time ago which replaces this script and makes it obsolete:
release/anago
Lines 440 to 502 in 397563c
Relates to #982