Use string builder to avoid copies on notes rendering #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/release-eng
This was referenced Dec 16, 2019
|
@hoegaarden, @cpanato @justaugustus may I ask for a review? :) |
k8s-ci-robot
added
the
do-not-merge/hold
|
Need rebase |
k8s-ci-robot
added
the
needs-rebase
We now use the `strings.Builder` to avoid a lot of copies during document rendering. Beside this, we render the markdown in a temporarily buffer before writing it into a file. This will be needed when it comes to the TOC generation which will be an intermediate step. Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
removed
the
needs-rebase
Rebased on top of the latest master. |
hoegaarden
suggested changes
Dec 19, 2019
The string builder always returns |
|
TIL:
👍 /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, hoegaarden, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use the
strings.Builderto avoid a lot of copiesduring document rendering.
Beside this, we render the markdown in a temporarily buffer before
writing it into a file. This will be needed when it comes to the TOC
generation which will be an intermediate step.