Add support for patch-to-patch discovery mode #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
area/release-eng
Merged
|
/retest |
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
saschagrunert
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
saschagrunert
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
This adds the patch release discovery method to the release notes
generator where it is now possible to generate the release notes by
only setting the appropriate release branch:
```
> go run cmd/release-notes/main.go \
--github-token <token> \
--branch release-1.16
--discover patch-to-patch
```
This results in an auto-discovery of the correct start and end SHAs:
```
INFO Parsing latest tag v1.16.4
INFO Parsing previous tag v1.16.3
INFO discovered start SHA b3cbbae08ec52a7fc73d334838e18d17e8512749
INFO discovered end SHA 224be7bdce5a9dd0c2fd0d46b83865648e2fe0ba
```
Signed-off-by: Sascha Grunert <[email protected]>
|
Ready for review, PTAL |
cpanato
approved these changes
Dec 13, 2019
k8s-ci-robot
added
the
lgtm
16 tasks
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the patch release discovery method to the release notes generator where it is now possible to generate the release notes by only setting the appropriate release branch:
This results in an auto-discovery of the correct start and end SHAs: