Refactor the rest of the git methods #937
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
area/release-eng
- We now checkout the target branch after clone/open - Added cleanup defer for repo as well - The working directory will now contain a link to the repo to make the go env rewrite work - `MergeBase` is now a method of `Repo` - `RevParse` and `RevParseShort` are now methods of `Repo` Signed-off-by: Sascha Grunert <[email protected]>
There was a problem hiding this comment.
@saschagrunert -- You're quick! Just one comment on whether or not there's a typo in here.
| if nomock { | ||
| log.Printf("nomock mode (from within ff)\n") | ||
| gitRoot := fmt.Sprintf("%s/src/k8s.io", workingDir) | ||
| if err := os.MkdirAll(gitRoot, 0o755); err != nil { |
There was a problem hiding this comment.
This is new in go 1.13, see https://golang.org/ref/spec#Integer_literals
I assume this is fine since we're only supporting this version, right? 😇
There was a problem hiding this comment.
Ohhhh, that's cool! TIL :)
...and yes, onwards to go1.13!
|
Thanks @saschagrunert! |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
to make the go env rewrite work
MergeBaseis now a method ofRepoRevParseandRevParseShortare now methods ofRepoSynchRepofunction is now obsolete since auth/clone/open works viaRepoI think as a next step we could refactor the rest of the
TODOs inff.go😇