Fix paths in shaNNNsums files #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@justinsb: Adding label: Reasons for blocking this PR:[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.] Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/blocked-paths
|
/assign @justaugustus This one is not as critical as #859, but fixes the shasums files to include the full relative paths. |
|
Not unrelated area, but it looks like a flake /retest |
tpepper
reviewed
Aug 23, 2019
lib/releaselib.sh
Outdated
| done | ||
| done | ||
| common::md5 $path > "$path.md5" || return 1 | ||
| common::sha $path 1 > "$path.sha1" || return 1 |
There was a problem hiding this comment.
I suggest we condition these two lines to run only if RELEASE_BRANCH is release-1.13, release-1.14, or release 1.15 and open an issue to remove this small block in six months when 1.15 goes out of support.
There was a problem hiding this comment.
That doesn't seem like a reasonable timeline to deprecate. We should announce now and then remove in some future release.
There was a problem hiding this comment.
this also costs very little to do, versus it may be painful to unbreak things that consume it.
There was a problem hiding this comment.
IMO these files are more like documentation, and potentially dangerously stale documentation at that, and should be tombstone-able and sunset more rapidly than a real API. I recognize there are other opinions.
There was a problem hiding this comment.
I don't think checksums are documentation. These are quite literally in the release artifacts and are a thing machine tooling depends on.
There was a problem hiding this comment.
I don't think checksums are documentation. These are quite literally in the release artifacts and are a thing machine tooling depends on.
I don't disagree in the abstract. Quality checksums should be dependable. In the case of our release process implementation, and in the case md5/sha1, I think machine tooling depending on many of our artifacts to be more than informational can become dangerous.
There was a problem hiding this comment.
Also I really question where the actionable information here will flow. Will the machine tooling read a deprecation notice? Will machine tooling owners read a deprecation notice? Are we actually minimizing any real world breakage, or just pushing it and associated fixes into the arbitrary future on the hope less breakage will happen. I think in this specific case we're giving the impression of applying an engineering change management process to replace hope and breakage but in a way that ultimately still just amounts to hope and breakage.
There was a problem hiding this comment.
md5 is a pretty reasonable non-security integrity check still, it's perfectly fine for checking if bits were flipped.
There was a problem hiding this comment.
we know at least one of them has and sent patches to move off of it (kops / @justinsb)
in any case, if we wish to remove these, we should create an issue to track deprecation, add it to the release notes as deprecated and announce when it will be removed. not just suddenly remove it.
BenTheElder
reviewed
Aug 23, 2019
lib/common.sh
Outdated
| # Get the md5 hash of a file | ||
| # @param file - The file | ||
| # @print the md5 hash | ||
| common::md5 () { |
There was a problem hiding this comment.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
hoegaarden
reviewed
Aug 27, 2019
lib/releaselib.sh
Outdated
| # We checksum everything except our checksum files, which we do next. | ||
| logecho "- Writing artifact hashes to SHA256SUMS/SHA512SUMS files..." | ||
| find "${gcs_stage}" -type f -printf '%P\0' | xargs -0 -I {} shasum -a 256 "${gcs_stage}/{}" >> SHA256SUMS | ||
| find "${gcs_stage}" -type f -printf '%P\0' | xargs -0 -I {} shasum -a 512 "${gcs_stage}/{}" >> SHA512SUMS |
lib/releaselib.sh
Outdated
| for sha_file in "${gcs_stage}"/*.sha"${bits}"; do | ||
| cat "$sha_file" >> "${gcs_stage}/SHA${bits}SUMS" | ||
| done | ||
| common::md5 $path > "$path.md5" || return 1 |
There was a problem hiding this comment.
See my requests / comments over at: #859 (review)
|
There's heavy overlap between this and #859. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/milestone v1.16 |
k8s-ci-robot
added
the
priority/important-soon
justinsb
force-pushed
the
fix_paths_in_shaNNNsums
branch
from
e247b31 to
3966d3b
Compare
k8s-ci-robot
added
size/XS
|
Kicked off a staging job to validate the output: RELEASE_TOOL_REPO='https://github.com/justinsb/release' \
RELEASE_TOOL_BRANCH='fix_paths_in_shaNNNsums' \
./gcbmgr stage release-1.15 --build-at-head
gcbmgr: BEGIN main on auggievmw01 Thu Aug 29 21:06:24 EDT 2019
Checking required system packages: OK
Checking /home/augustus/go/src/k8s.io/release state: OK
Checking/setting cloud tools: OK
Trying to get kubecross version for release-1.15 ... OK: v1.12.9-1
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
STAGE fdbce763-e6d5-478f-baa0-fdc1db9e75d9 submitted successfully.
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
To view last build:
$ gcbmgr tail
To view this specific build:
$ gcbmgr tail fdbce763-e6d5-478f-baa0-fdc1db9e75d9
-OR-
$ /usr/bin/gcloud --project kubernetes-release-test builds log --stream fdbce763-e6d5-478f-baa0-fdc1db9e75d9
-OR-
https://console.cloud.google.com/gcr/builds/fdbce763-e6d5-478f-baa0-fdc1db9e75d9?project=648026197307
gcbmgr: DONE main on auggievmw01 Thu Aug 29 21:06:27 EDT 2019 in 3s |
|
@justaugustus 859's merged, is there anything else you require of this one? |
justaugustus
requested changes
Sep 4, 2019
There was a problem hiding this comment.
@justinsb -- In trying to validate this, I noticed that the SHANNNSUMS don't make it to the staging bucket:
$ gsutil ls gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-darwin-386.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-darwin-386.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-darwin-386.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-darwin-amd64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-darwin-amd64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-darwin-amd64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-386.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-386.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-386.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-amd64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-amd64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-amd64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-arm.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-arm.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-arm.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-arm64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-arm64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-arm64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-ppc64le.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-ppc64le.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-ppc64le.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-s390x.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-s390x.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-linux-s390x.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-windows-386.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-windows-386.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-windows-386.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-windows-amd64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-windows-amd64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-client-windows-amd64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-manifests.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-manifests.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-manifests.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-amd64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-amd64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-amd64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-arm.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-arm.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-arm.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-arm64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-arm64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-arm64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-ppc64le.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-ppc64le.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-ppc64le.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-s390x.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-s390x.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-linux-s390x.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-windows-amd64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-windows-amd64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-node-windows-amd64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-amd64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-amd64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-amd64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-arm.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-arm.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-arm.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-arm64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-arm64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-arm64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-ppc64le.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-ppc64le.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-ppc64le.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-s390x.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-s390x.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-server-linux-s390x.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-src.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-src.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-src.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-darwin-amd64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-darwin-amd64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-darwin-amd64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-amd64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-amd64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-amd64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-arm.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-arm.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-arm.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-arm64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-arm64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-arm64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-ppc64le.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-ppc64le.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-ppc64le.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-s390x.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-s390x.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-linux-s390x.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-portable.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-portable.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-portable.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-windows-amd64.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-windows-amd64.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test-windows-amd64.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes-test.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes.tar.gz
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes.tar.gz.sha256
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/kubernetes.tar.gz.sha512
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/bin/
gs://kubernetes-release-gcb/stage/v1.17.0-alpha.0.928+a9f0db16614ae6/v1.17.0-alpha.1/gcs-stage/v1.17.0-alpha.1/extra/I've made some code suggestions that should fix that and once they're integrated, this should be ready to merge.
cc: @tpepper
lib/releaselib.sh
Outdated
| # Write the release checksum files. | ||
| # We checksum everything except our checksum files, which we do next. | ||
| logecho "- Writing artifact hashes to SHA256SUMS/SHA512SUMS files..." | ||
| find "${gcs_stage}" -type f -printf '%P\0' | xargs -0 -I {} shasum -a 256 "${gcs_stage}/{}" >> SHA256SUMS |
There was a problem hiding this comment.
Suggested change
| find "${gcs_stage}" -type f -printf '%P\0' | xargs -0 -I {} shasum -a 256 "${gcs_stage}/{}" >> SHA256SUMS | |
| find "${gcs_stage}" -type f -printf '%P\0' | xargs -0 -I {} shasum -a 256 "${gcs_stage}/{}" >> "${gcs_stage}/SHA256SUMS" |
lib/releaselib.sh
Outdated
| # We checksum everything except our checksum files, which we do next. | ||
| logecho "- Writing artifact hashes to SHA256SUMS/SHA512SUMS files..." | ||
| find "${gcs_stage}" -type f -printf '%P\0' | xargs -0 -I {} shasum -a 256 "${gcs_stage}/{}" >> SHA256SUMS | ||
| find "${gcs_stage}" -type f -printf '%P\0' | xargs -0 -I {} shasum -a 512 "${gcs_stage}/{}" >> SHA512SUMS |
There was a problem hiding this comment.
Suggested change
| find "${gcs_stage}" -type f -printf '%P\0' | xargs -0 -I {} shasum -a 512 "${gcs_stage}/{}" >> SHA512SUMS | |
| find "${gcs_stage}" -type f -printf '%P\0' | xargs -0 -I {} shasum -a 512 "${gcs_stage}/{}" >> "${gcs_stage}/SHA512SUMS" |
We should include the full relative path in our shaNNNsums files.
justinsb
force-pushed
the
fix_paths_in_shaNNNsums
branch
from
3966d3b to
e54d530
Compare
|
Fixed @justaugustus - thanks for sanity checking and finding the problem! |
|
Thanks @justinsb! |
|
Thanks again, @justinsb! GCS bucket output:SHA256SUMSSHA512SUMS/lgtm |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, justaugustus, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
justaugustus
removed
the
do-not-merge/blocked-paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should include the full relative path in our shaNNNsums files.