Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump distroless-iptables to use go1.22.9 and go1.23.3 #3829

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Nov 12, 2024

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

  • bump distroless-iptables to use go1.22.9 and go1.23.3

/assign @xmudrii @saschagrunert @Verolop
cc @kubernetes/release-managers

Which issue(s) this PR fixes:

xref: #3819

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- bump distroless-iptables to use go1.22.9 and go1.23.3

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 12, 2024
@xmudrii
Copy link
Member

xmudrii commented Nov 13, 2024

@cpanato What's the reason for bumping the minor version for these images? I don't remember that we were doing that earlier for Go updates. Are there any other changes? If yes, should we mention them in the release note?

@cpanato
Copy link
Member Author

cpanato commented Nov 13, 2024

@cpanato What's the reason for bumping the minor version for these images? I don't remember that we were doing that earlier for Go updates. Are there any other changes? If yes, should we mention them in the release note?

not sure if a follow you? we bumped go-runner to 2.4.0 just using here, do you want to bump minor for distroless as well?
if yes, i will need to build 2.3.1 for go 1.22.x as we cannot bump the 0.5.x for distroless, but that will be deprecated soon

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2024
@saschagrunert
Copy link
Member

saschagrunert commented Nov 13, 2024

/hold

for clarification on the version

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@xmudrii
Copy link
Member

xmudrii commented Nov 13, 2024

@cpanato I was wondering why is the go-runner version bumped from v2.3.1 to v2.4.0, but I see that's because of #3820 and #3816, which makes sense!
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8c20bfb into kubernetes:master Nov 13, 2024
12 checks passed
@cpanato cpanato deleted the update-distroless branch November 14, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants