Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newer golang patch (1.22.7, 1.23.1) sep2024 #3758

Merged

Conversation

haitch
Copy link
Contributor

@haitch haitch commented Sep 12, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Build Go 1.22.6 images for currently supported Kubernetes release branches
  • Build Go 1.23.1 images for currently supported Kubernetes release branches

Which issue(s) this PR fixes:

Build Go 1.23.1 and 1.22.7 images

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 12, 2024
@k8s-ci-robot k8s-ci-robot added needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Sep 12, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @haitch!

It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 12, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @haitch. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 12, 2024
@ameukam
Copy link
Member

ameukam commented Sep 16, 2024

cc @cpanato

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update dependencies.yaml.

You can take a look at #3724 as an inspiration how the initial Go update step looks like.

Thank you for the contribution!

images/build/go-runner/Makefile Show resolved Hide resolved
images/k8s-cloud-builder/variants.yaml Outdated Show resolved Hide resolved
images/releng/k8s-ci-builder/variants.yaml Outdated Show resolved Hide resolved
@cpanato
Copy link
Member

cpanato commented Sep 17, 2024

I will review this PR this week, most likely tomorrow

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2024
@cpanato
Copy link
Member

cpanato commented Sep 17, 2024

also please rebase and squash the commits

@haitch
Copy link
Contributor Author

haitch commented Sep 17, 2024

thanks for the review @xmudrii @cpanato , working on the rebase now.

@haitch
Copy link
Contributor Author

haitch commented Sep 17, 2024

need ok-to-test label

@xmudrii
Copy link
Member

xmudrii commented Sep 17, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 17, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 17, 2024
@haitch haitch force-pushed the haitao/newer_golang_patch_sep2024 branch from bfeb924 to bb3c865 Compare September 17, 2024 20:20
@haitch
Copy link
Contributor Author

haitch commented Sep 17, 2024

/retest-required

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 18, 2024

@haitch: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-release-image-distroless-iptables bfeb924 link true /test pull-release-image-distroless-iptables

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, @haitch!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2024
@xmudrii
Copy link
Member

xmudrii commented Sep 18, 2024

We hit the quota on the kube-cross test
/retest

@xmudrii
Copy link
Member

xmudrii commented Sep 18, 2024

xref #3738
/release-note-edit

Build Go 1.23.1 and 1.22.7 images

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed needs-priority do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 18, 2024
@xmudrii
Copy link
Member

xmudrii commented Sep 18, 2024

/release-note-edit

Build Go 1.23.1 and 1.22.7 images

@xmudrii
Copy link
Member

xmudrii commented Sep 18, 2024

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 18, 2024
@xmudrii xmudrii changed the title newer golang patch (1.22.7, 1.23.0) sep2024 newer golang patch (1.22.7, 1.23.1) sep2024 Sep 18, 2024
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @haitch

as soon we merge this you need to watch https://prow.k8s.io/?repo=kubernetes%2Frelease to see if the post submits jobs succeed then we can do the image promotion

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, haitch, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cpanato
Copy link
Member

cpanato commented Sep 19, 2024

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9eca193 into kubernetes:master Sep 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants