-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
newer golang patch (1.22.7, 1.23.1) sep2024 #3758
newer golang patch (1.22.7, 1.23.1) sep2024 #3758
Conversation
Welcome @haitch! |
Hi @haitch. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc @cpanato |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to update dependencies.yaml
.
You can take a look at #3724 as an inspiration how the initial Go update step looks like.
Thank you for the contribution!
I will review this PR this week, most likely tomorrow /hold |
also please rebase and squash the commits |
02d78fb
to
36c1e7f
Compare
need ok-to-test label |
/ok-to-test |
bfeb924
to
bb3c865
Compare
/retest-required |
@haitch: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, @haitch!
/lgtm
/approve
We hit the quota on the kube-cross test |
xref #3738
/priority important-soon |
/release-note-edit
|
/label tide/merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @haitch
as soon we merge this you need to watch https://prow.k8s.io/?repo=kubernetes%2Frelease to see if the post submits jobs succeed then we can do the image promotion
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, haitch, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes: