Remove socat and ebtables dependencies from the kubelet package #3722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/release
saschagrunert
approved these changes
Aug 22, 2024
k8s-ci-robot
added
the
lgtm
aojea
reviewed
Aug 22, 2024
|
/lgtm |
Signed-off-by: Marko Mudrinić <[email protected]>
k8s-ci-robot
removed
the
lgtm
xmudrii
changed the title
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
saschagrunert
approved these changes
Aug 27, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
we should remove these from kubeadm preflight too. similar pr for conntrack, except for these it can be remove without version checks. |
saschagrunert
added a commit
to saschagrunert/kubernetes
that referenced
this pull request
Sep 5, 2024
Follow-up on kubernetes/release#3722 Signed-off-by: Sascha Grunert <[email protected]>
Makes sense: kubernetes/kubernetes#127151 |
SoulPancake
pushed a commit
to SoulPancake/k8s
that referenced
this pull request
Sep 11, 2024
Follow-up on kubernetes/release#3722 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/kubernetes
that referenced
this pull request
Sep 17, 2024
Follow-up on kubernetes/release#3722 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/kubernetes
that referenced
this pull request
Sep 17, 2024
Follow-up on kubernetes/release#3722 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/kubernetes
that referenced
this pull request
Sep 17, 2024
Follow-up on kubernetes/release#3722 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
added a commit
to saschagrunert/kubernetes
that referenced
this pull request
Sep 17, 2024
Follow-up on kubernetes/release#3722 Signed-off-by: Sascha Grunert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
As per #3707 (comment) and kubernetes/kubernetes#100679, the
socatdependency is no longer required.As per #3722 (comment), the
ebtablesdependency is no longer required.This PR removes both dependencies from the kubelet package.
Given that this change is in effect since v1.22, I believe it's okay to just remove it from the spec file without adding special cases in
metadata.yaml.Which issue(s) this PR fixes:
Fixes #3707
Does this PR introduce a user-facing change?
/assign @saschagrunert
cc @kubernetes/release-engineering @aojea
/hold
pending the final confirmation #3707 (comment)