Allow string slices as krel obs arguments
#3267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
k8s-ci-robot
added
the
lgtm
xmudrii
requested changes
Sep 13, 2023
k8s-ci-robot
removed
the
lgtm
This fixes the usage of packages and architectures as mentioned in kubernetes#3224 by using a custom separator. We cannot use the GCB separator substitution (see `gcloud topic escaping`) because GCB complains that a 'build tag must match format "^[\\w][\\w.-]{0,127}$"'. Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert
force-pushed
the
arches
branch
from
dae6097
to
8770eb7
Compare
xmudrii
approved these changes
Sep 13, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This fixes the usage of packages and architectures as mentioned in #3224 by using a custom separator.
We cannot use the GCB separator substitution (see
gcloud topic escaping) because GCB complains that a 'build tag must match format "^[\w][\w.-]{0,127}$"'.Which issue(s) this PR fixes:
Fixes #3224
Special notes for your reviewer:
Tested via:
https://console.cloud.google.com/cloud-build/builds/8480b7dd-2b36-44c2-87c1-f2af0caeaac6?project=648026197307
Does this PR introduce a user-facing change?