-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade base image kubepkg-rpm to fedora:39 #3264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @xmudrii any reason to keep it at Fedora 30?
/hold
@saschagrunert This is for (old) kubepkg and I'm not sure if we even use it in any way. We should probably consider deprecating and removing this image (and kubepkg in general). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacoxu, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I can take care of that, let's get a note out to k-dev and create a tracking issue for that. |
/unhold |
Sounds good to me! |
Ref #3265 |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
follow kubernetes/test-infra#30603
Which issue(s) this PR fixes:
xref kubernetes/kubernetes#120591
Special notes for your reviewer:
Does this PR introduce a user-facing change?