Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade base image kubepkg-rpm to fedora:39 #3264

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Sep 12, 2023

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

follow kubernetes/test-infra#30603

  • but fedora only has some new versions. The latest is 39.

Which issue(s) this PR fixes:

xref kubernetes/kubernetes#120591

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng Issues or PRs related to the Release Engineering subproject labels Sep 12, 2023
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 12, 2023
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @xmudrii any reason to keep it at Fedora 30?

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 12, 2023
@xmudrii
Copy link
Member

xmudrii commented Sep 12, 2023

@saschagrunert This is for (old) kubepkg and I'm not sure if we even use it in any way. We should probably consider deprecating and removing this image (and kubepkg in general).

Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacoxu, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@saschagrunert
Copy link
Member

@saschagrunert This is for (old) kubepkg and I'm not sure if we even use it in any way. We should probably consider deprecating and removing this image (and kubepkg in general).

I can take care of that, let's get a note out to k-dev and create a tracking issue for that.

@saschagrunert
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 12, 2023
@xmudrii
Copy link
Member

xmudrii commented Sep 12, 2023

I can take care of that, let's get a note out to k-dev and create a tracking issue for that.

Sounds good to me!

@saschagrunert
Copy link
Member

Ref #3265

@k8s-ci-robot k8s-ci-robot merged commit 7072b72 into kubernetes:master Sep 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants