Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate CRI-O into krel obs #3229

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 25, 2023

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adding the CRI-O v1.28.0 package to krel obs.

Which issue(s) this PR fixes:

Refers to #3214

Special notes for your reviewer:

Requires #3224 to exclude s390x, because CRI-O does not ship this arch for now.

Therefore
/hold

Testing the specfile in https://build.opensuse.org/package/show/isv:kubernetes:core:shared:build/cri-o

Does this PR introduce a user-facing change?

Added CRI-O package to `krel obs`

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Aug 25, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 25, 2023
@saschagrunert
Copy link
Member Author

@haircommander PTAL

@haircommander
Copy link

wow, fast turn around! thanks, LGTM 😄

@saschagrunert
Copy link
Member Author

Thanks!

@xmudrii PTAL, too. :)

@xmudrii
Copy link
Member

xmudrii commented Aug 27, 2023

@saschagrunert There's a few thing that I want to look into relevant to this PR. I'll prioritize this and get back to you as soon as possible. 🙂

@xmudrii
Copy link
Member

xmudrii commented Aug 27, 2023

/assign

Signed-off-by: Sascha Grunert <[email protected]>
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this merged and then we can iterate on this later.
/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a92f4f2 into kubernetes:master Sep 13, 2023
4 checks passed
@saschagrunert saschagrunert deleted the cri-o branch September 13, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants