Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setcap: switch to debian bookworm #3139

Merged
merged 1 commit into from
Jul 11, 2023
Merged

setcap: switch to debian bookworm #3139

merged 1 commit into from
Jul 11, 2023

Conversation

saschagrunert
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update setcap image to use debian bookworm.

Which issue(s) this PR fixes:

Refers to #3128

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

Updated setcap image to use debian bookworm.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jul 5, 2023
@saschagrunert saschagrunert mentioned this pull request Jul 5, 2023
Closed
44 tasks
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2023
@saschagrunert saschagrunert force-pushed the setcap-bookworm branch 2 times, most recently from f31cd0e to 513636e Compare July 5, 2023 08:45
@saschagrunert
Copy link
Member Author

/test pull-release-test

cpanato
cpanato reviewed Jul 5, 2023
View reviewed changes
images/build/setcap/variants.yaml Outdated
@@ -1,6 +1,5 @@
variants:
# Debian 11 - Kubernetes 1.23 and newer
bullseye:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we drop this? are we planning to update all release branches with the new one? otherwise i would keep this and update the comments

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, readded the Debian 11 variants.

@saschagrunert
Copy link
Member Author

/test pull-release-test

@saschagrunert
Copy link
Member Author

/retest

@saschagrunert
Copy link
Member Author

@kubernetes/release-engineering PTAL

@cpanato
Copy link
Member

cpanato commented Jul 11, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Jul 11, 2023

/test pull-release-integration-test

@cpanato
Copy link
Member

cpanato commented Jul 11, 2023

need to wait an hour to be sure we clean the rate limit

@saschagrunert
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 9f41d80 into kubernetes:master Jul 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jul 11, 2023
@saschagrunert saschagrunert deleted the setcap-bookworm branch July 11, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@xmudrii xmudrii xmudrii approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@salaxander salaxander Awaiting requested review from salaxander

Assignees

@cpanato cpanato

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @cpanato @k8s-ci-robot @xmudrii