Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump k8s-cloud-builder and k8s-ci-builder to Go 1.19.4 and Go 1.18.9 #2795

Merged
merged 2 commits into from
Dec 7, 2022
Merged

Bump k8s-cloud-builder and k8s-ci-builder to Go 1.19.4 and Go 1.18.9 #2795

merged 2 commits into from
Dec 7, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Dec 5, 2022 •
edited
Loading

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Which issue(s) this PR fixes:

Part of #2788

Does this PR introduce a user-facing change?

- Build k8s-cloud-builder and k8s-ci-builder using Go 1.19.4
- Build k8s-cloud-builder and k8s-ci-builder using Go 1.18.9
- Build k8s-cloud-builder image based on kube-cross v1.26.0 (`v1.26-cross1.19-bullseye`)

cc @kubernetes/release-engineering

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Dec 5, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 5, 2022
@xmudrii xmudrii mentioned this pull request Dec 5, 2022
Closed
21 tasks
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2022
@xmudrii xmudrii marked this pull request as ready for review December 7, 2022 16:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Dec 7, 2022

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority labels Dec 7, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Dec 7, 2022

/hold
There's an issue with the k8s-cloud-builder image.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Dec 7, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2022
@jeremyrickard
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2022
palnabarun
palnabarun approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: palnabarun, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Dec 7, 2022

/test all

@k8s-ci-robot k8s-ci-robot merged commit 15a8b77 into kubernetes:master Dec 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Dec 7, 2022
@xmudrii xmudrii deleted the go-1194-1189-cloud-builder branch December 7, 2022 17:33
cpanato
cpanato reviewed Dec 13, 2022
View reviewed changes
images/k8s-cloud-builder/variants.yaml
@@ -1,10 +1,13 @@
variants:
v1.26-cross1.19-bullseye:
CONFIG: 'cross1.19'
KUBE_CROSS_VERSION: 'v1.26.0-go1.19.4-bullseye.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be v1.26.0-go1.19.4-bullseye.0 and not with .1 but that is ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized that at some point, but I got confused for some reason while updating this image. 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries

@cpanato cpanato mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato left review comments

@palnabarun palnabarun palnabarun approved these changes

@BenjaminKazemi BenjaminKazemi Awaiting requested review from BenjaminKazemi

@cici37 cici37 Awaiting requested review from cici37

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@palnabarun palnabarun

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
5 participants
@xmudrii @k8s-ci-robot @jeremyrickard @cpanato @palnabarun