Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop building rc.0 versions after official patches #2765

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Stop building rc.0 versions after official patches #2765

merged 1 commit into from
Mar 9, 2023

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Nov 15, 2022 •
edited
Loading

What type of PR is this?

/kind deprecation

What this PR does / why we need it:

We now do not build release candidates after official patches any more.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Testing
export TOOL_ORG=saschagrunert TOOL_REF=official-patches-no-rc && \
go run ./cmd/krel stage --type=official --branch=release-1.25

✔️ https://console.cloud.google.com/cloud-build/builds/a08abe6e-0508-4f72-aa98-41e0770124df?project=kubernetes-release-test

export TOOL_ORG=saschagrunert TOOL_REF=official-patches-no-rc && \
go run ./cmd/krel release --type=official --branch=release-1.25 --build-version=v1.25.5-rc.0.1+21e06572c3bcd7

✔️ https://console.cloud.google.com/cloud-build/builds;region=global/24495dd9-26f5-4ff4-af28-05bef74c350c?project=kubernetes-release-test

Does this PR introduce a user-facing change?

Changed patch release process to stop building rc.0 versions together with the official.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Nov 15, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2022
cpanato
cpanato approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2023
@jeremyrickard
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2023
@jimangel
Copy link
Member

Does this impact only patches? Another way of asking, are we still going to cut rc.0s for new major releases?

@saschagrunert
Copy link
Member Author

Does this impact only patches? Another way of asking, are we still going to cut rc.0s for new major releases?

Yes 👍

@ameukam
Copy link
Member

ameukam commented Feb 27, 2023

/lgtm

@saschagrunert saschagrunert changed the title WIP: Stop building rc.0 versions after official patches Stop building rc.0 versions after official patches Mar 9, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 9, 2023
@saschagrunert
Copy link
Member Author

Lazy consensus reached per https://groups.google.com/g/kubernetes-sig-release/c/z5d0V-6zKvg

@saschagrunert saschagrunert added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Mar 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6891f44 into kubernetes:master Mar 9, 2023
@saschagrunert saschagrunert deleted the official-patches-no-rc branch March 9, 2023 08:43
@puerco puerco mentioned this pull request Mar 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@mkorbi mkorbi Awaiting requested review from mkorbi

@thejoycekung thejoycekung Awaiting requested review from thejoycekung

Assignees

@ameukam ameukam

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@saschagrunert @k8s-ci-robot @k8s-triage-robot @jeremyrickard @jimangel @ameukam @cpanato