Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure it's possible to build rpms generated by kubepkg #2712

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Ensure it's possible to build rpms generated by kubepkg #2712

merged 1 commit into from
Oct 17, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 15, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR modifies templates for generating rpms to ensure it's possible to build those rpms using rpmbuild. Currently, it's not possible to build rpms generated by kubepkg because of various errors. One of those errors is described in #2703

Which issue(s) this PR fixes:

Fixes #2703

Does this PR introduce a user-facing change?

Ensure it's possible to build rpms generated by kubepkg

cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Oct 15, 2022
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Oct 15, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 15, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Oct 15, 2022

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority labels Oct 15, 2022
@dims
Copy link
Member

dims commented Oct 15, 2022

/approve
/lgtm
/hold feel free to remove hold when ready @xmudrii

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 15, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2022
saschagrunert
saschagrunert approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d182780 into kubernetes:master Oct 17, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 17, 2022
@xmudrii xmudrii deleted the kubepkg-fix-rpms branch October 17, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@cpanato cpanato Awaiting requested review from cpanato

@wilsonehusin wilsonehusin Awaiting requested review from wilsonehusin

Assignees

@dims dims

@saschagrunert saschagrunert

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

rpmbuild using spec generated by spec-only for kubelet not working
4 participants
@xmudrii @dims @k8s-ci-robot @saschagrunert