Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Go 1.19.1 and 1.18.6 based images #2659

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

palnabarun
Copy link
Member

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

Build Go 1.19.1 and 1.18.6 based images

Which issue(s) this PR fixes:

Part of #2658

Does this PR introduce a user-facing change?

Build Go 1.19.1 and 1.18.6 based images

/cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot requested a review from a team September 7, 2022 05:57
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 7, 2022
@palnabarun
Copy link
Member Author

/test pull-release-image-go-runner

@palnabarun
Copy link
Member Author

/test pull-release-image-go-runner

1 similar comment
@Verolop
Copy link
Contributor

Verolop commented Sep 7, 2022

/test pull-release-image-go-runner

@Verolop
Copy link
Contributor

Verolop commented Sep 7, 2022

/retest-required

@Verolop
Copy link
Contributor

Verolop commented Sep 7, 2022

/test pull-release-image-go-runner

@Verolop
Copy link
Contributor

Verolop commented Sep 7, 2022

/test pull-release-image-kubepkg

@palnabarun
Copy link
Member Author

All tests are passing! 🥳

Thanks, @Verolop, for the retries!!!

@Verolop
Copy link
Contributor

Verolop commented Sep 7, 2022

@palnabarun yeah, Carlos warned me last night that it might take several re-tries. Thanks for the PR

@Verolop
Copy link
Contributor

Verolop commented Sep 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks @palnabarun & @Verolop

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, palnabarun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6669802 into kubernetes:master Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 7, 2022
@palnabarun palnabarun deleted the go-updates branch September 7, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants