Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CNI plugins to v1.1.1 #2650

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Update CNI plugins to v1.1.1 #2650

merged 1 commit into from
Aug 30, 2022

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Aug 30, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update CNI plugins to the latest release.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Uploaded the artifacts to: https://console.cloud.google.com/storage/browser/k8s-artifacts-cni/release/v1.1.1

> kpromo gh --org containernetworking --repo plugins --bucket k8s-artifacts-cni --release-dir release --tags v1.1.1

Does this PR introduce a user-facing change?

Updated CNI plugins to v1.1.1

@saschagrunert
Update CNI plugins to v1.1.1
e35146e 
Signed-off-by: Sascha Grunert <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 30, 2022
@saschagrunert
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
@saschagrunert
Copy link
Member Author

/unhold

@justaugustus please take a look at this one, too.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
cpanato
cpanato approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

adding a hold becasue sascha asked for feedback from stephen, if that is not needed anymore can lift the hold

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
justaugustus
justaugustus approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sascha!
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fcd7c10 into kubernetes:master Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 30, 2022
@saschagrunert saschagrunert deleted the cni-plugins-1.1.1 branch August 30, 2022 16:21
@saschagrunert saschagrunert mentioned this pull request Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@justaugustus justaugustus justaugustus approved these changes

@jimangel jimangel Awaiting requested review from jimangel

@mkorbi mkorbi Awaiting requested review from mkorbi

Assignees

@justaugustus justaugustus

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.
4 participants
@saschagrunert @k8s-ci-robot @justaugustus @cpanato