Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add k8s-cloud-builder for go1.19 #2631

Merged
merged 1 commit into from
Aug 4, 2022
Merged

add k8s-cloud-builder for go1.19 #2631

merged 1 commit into from
Aug 4, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Aug 4, 2022

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

  • k8s-cloud-builder: build using Go 1.19

Which issue(s) this PR fixes:

xref #2575

Does this PR introduce a user-facing change?

- k8s-cloud-builder: build using Go 1.19

/assign @saschagrunert @xmudrii @Verolop @puerco @dims
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added the area/dependency Issues or PRs related to dependency changes label Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2022
@ameukam
Copy link
Member

ameukam commented Aug 4, 2022

/lgtm

palnabarun
palnabarun approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@palnabarun palnabarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@palnabarun
Copy link
Member

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority labels Aug 4, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, palnabarun, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dfeb9af into kubernetes:master Aug 4, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Aug 4, 2022
@cpanato cpanato deleted the cloud-builder-go119 branch August 4, 2022 12:32
@ameukam ameukam mentioned this pull request Aug 4, 2022
Closed
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@palnabarun palnabarun palnabarun approved these changes

@mkorbi mkorbi Awaiting requested review from mkorbi

@sethmccombs sethmccombs Awaiting requested review from sethmccombs

Assignees

@dims dims

@saschagrunert saschagrunert

@Verolop Verolop

@ameukam ameukam

@puerco puerco

@palnabarun palnabarun

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
9 participants
@cpanato @ameukam @palnabarun @k8s-ci-robot @xmudrii @dims @saschagrunert @Verolop @puerco