Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krel/ff: add an option to define a gcp project to use instead of the default one #2414

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 8, 2022

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

  • krel/ff: add an option to define a GCP project to use instead of the default one

The prow job that we setup (kubernetes/test-infra#25140) does not have access to kubernetes-release-test which is an older and not community-owned GCP project, and we need to work on a plan to deprecate this project, but for now we offer an option for the krel/ff command to choose which GCP project to use (and default that to k8s-staging-releng-test)

/assign @saschagrunert @ameukam
cc @kubernetes/release-engineering

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

krel/ff: add an option to define a gcp project to use instead of the default one

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added the area/release-eng Issues or PRs related to the Release Engineering subproject label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2022
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Can we do a manual test run in k8s-staging-releng-test?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@cpanato
Copy link
Member Author

cpanato commented Feb 8, 2022

yes, will run it @saschagrunert gibe me some minutes

cmd/krel/cmd/ff.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 8, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2022
@palnabarun
Copy link
Member

/lgtm

@cpanato
Copy link
Member Author

cpanato commented Feb 9, 2022

ran a test with this change

Step #2: krel was successfully compiled and installed to /workspace/bin/krel
Finished Step #2
Starting Step #3
Step #3: Already have image (with digest): gcr.io/k8s-staging-releng/k8s-cloud-builder:v1.24.0-go1.17.6-bullseye.0
Step #3: level=info msg="Preparing to fast-forward from origin/master"
Step #3: level=info msg="Found GitHub token, using it for repository interactions"
Step #3: level=info msg="Cloning repository by using HTTPs"
Step #3: level=info msg="Using dry mode, which does not modify any remote content"
Step #3: level=info msg="No release branch specified, finding the latest"
Step #3: level=info msg="Found latest release branch: release-1.23"
Step #3: level=info msg="Tag v1.23.0 found in default remote"
Step #3: level=info msg="Fast forward not required because final tag already exists for latest release branch release-1.23"
Finished Step #3
PUSH
DONE

@cpanato
Copy link
Member Author

cpanato commented Feb 9, 2022

thanks so much for @ameukam @saschagrunert for the debug session

@cpanato
Copy link
Member Author

cpanato commented Feb 9, 2022

@saschagrunert are you ok to lift the hold?

@ameukam
Copy link
Member

ameukam commented Feb 9, 2022

/lgtm

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c8856b0 into kubernetes:master Feb 9, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 9, 2022
@cpanato cpanato deleted the update-ff-gcp-project branch February 9, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants