-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
krel/ff: add an option to define a gcp project to use instead of the default one #2414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Can we do a manual test run in k8s-staging-releng-test
?
yes, will run it @saschagrunert gibe me some minutes |
…default one Signed-off-by: Carlos Panato <[email protected]>
1fcc282
to
becad20
Compare
/lgtm |
ran a test with this change
|
thanks so much for @ameukam @saschagrunert for the debug session |
@saschagrunert are you ok to lift the hold? |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/unhold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind feature
What this PR does / why we need it:
The prow job that we setup (kubernetes/test-infra#25140) does not have access to
kubernetes-release-test
which is an older and not community-owned GCP project, and we need to work on a plan to deprecate this project, but for now we offer an option for the krel/ff command to choose which GCP project to use (and default that tok8s-staging-releng-test
)/assign @saschagrunert @ameukam
cc @kubernetes/release-engineering
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?