Release Process: Write SLSA v0.2 provenance attestations #2375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adolfo García Veytia <[email protected]>
Migrate provenance predicate fields to SLSA v0.2 equivalents. Also, reference the DigestSets from the new versioned SLSA package. Signed-off-by: Adolfo García Veytia <[email protected]>
This commit removes the temporary logic to lookup the last commit SHA in favor of the function in the release-sdk `git` package. Signed-off-by: Adolfo García Veytia <[email protected]>
Signed-off-by: Adolfo García Veytia <[email protected]>
This commit addresses nits noted in kubernetes#2273. Signed-off-by: Adolfo García Veytia <[email protected]>
krel arguments recorded in the provenance attestation were recorded
with dashes and equal signs:
```
"arguments": {
"--branch=": "master",
```
This commit fixes them to record just the name of the parameter.
Signed-off-by: Adolfo García Veytia <[email protected]>
k8s-ci-robot
added
release-note
puerco
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR modifies the Kubernetes release process to write its provenance attestations using the latest SLSA 0.2 spec. Except for newer fields in the attestation predicate, content is mostly the same, it just has been migrated from 0.1 to the equivalent 0.2 fields.
This PR also addresses the comments noted in #2273 (/cc @justaugustus )
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
/cc @kubernetes/release-engineering @justaugustus @cpanato
Test runs of the new code:
Stage:
https://console.cloud.google.com/cloud-build/builds;region=global/f464f9a1-dac8-4090-8a00-bd5ae56e72c5?project=kubernetes-release-test
Release:
https://console.cloud.google.com/cloud-build/builds;region=global/bfc36ac7-c558-4f84-95ae-76ca1de6f546?project=kubernetes-release-test
Does this PR introduce a user-facing change?