Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SBOM generation support to publish-release #2372

Merged
merged 2 commits into from
Dec 19, 2021

Conversation

puerco
Copy link
Member

@puerco puerco commented Dec 17, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

This commit adds SBOM generation support to the publish-release utility:

image

The generated SPDX SBOM describes the source code repo and all the artifacts uploaded to the GitHub release page.

A new flag --sbom (defaulting to true) controls if the utility generates an SBOM and attaches
it to the github release page when uploading data for a release.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

To see an example of the generated SBOM check out this repository:
https://github.com/mattermost/builder/releases/tag/v0.0.1

Does this PR introduce a user-facing change?

Our utility to manage release publishing  `publish-release`, now automatically generates an SBOM describing the source code repository and all artifacts uploaded as assets to the GitHub release page.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit adds SBOM generation support to the publish-release utility.
A new flag --sbom (defaulting to true) controls if the utility generates
an SBOM and attaches it to the github release page.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2021
@puerco puerco changed the title Release refactor Add SBOM generation support to publish-release Dec 17, 2021
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, puerco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 036befb into kubernetes:master Dec 19, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants