krel: fix layout used to parse GCB time #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layout we currently use doesn't work well if GCB returns time that has less than 6 digits in seconds fraction. In such cases, it returns an error such as: parsing the end job time: parsing time "2021-12-15T13:25:53.713850050Z" as "2006-01-02T15:04:05.000000Z": cannot parse "050Z" as "Z" In this concrete case -- where we pass time returned by GCB, we want to allow any number of digits in the seconds fraction. Signed-off-by: Marko Mudrinić <[email protected]>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
sig/release
saschagrunert
approved these changes
Dec 16, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
The layout we currently use doesn't work well if GCB returns a time that has less than 9 digits in seconds fraction. In such cases, it returns an error such as:
This error can be reproduced by running the following
krel historycommand:In this concrete case -- where we pass time returned by GCB, we want to allow any number of digits in seconds fraction.
Which issue(s) this PR fixes:
None
Does this PR introduce a user-facing change?