Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: Default to bullesye variants and cleanup EOL components #2323

Merged
merged 2 commits into from
Nov 16, 2021
Merged

images: Default to bullesye variants and cleanup EOL components #2323

merged 2 commits into from
Nov 16, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind cleanup
/area dependency

What this PR does / why we need it:

  • debian: Default to bullseye variants

  • images: Stop attempting to build outdated variants

    Drops variants that:

    • have outdated versions of golang
    • are building for EOL release branches

Signed-off-by: Stephen Augustus [email protected]

/assign @Verolop @xmudrii
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- debian: Default to `bullseye` variants
- images: Stop attempting to build outdated variants

  Drops variants that:
  - have outdated versions of golang
  - are building for EOL release branches

@justaugustus
debian: Default to bullseye variants
3a48702 
Signed-off-by: Stephen Augustus <[email protected]>
@justaugustus
images: Stop attempting to build outdated variants
8e7e2eb 
Drops variants that:
- have outdated versions of golang
- are building for EOL release branches

Signed-off-by: Stephen Augustus <[email protected]>
xmudrii
xmudrii reviewed Nov 16, 2021
View reviewed changes
images/releng/ci/variants.yaml
Comment on lines -17 to -21
go1.15-buster:
CONFIG: 'go1.15-buster'
GO_VERSION: '1.15.15'
OS_CODENAME: 'buster'
REVISION: '0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't 1.15 still used by 1.20? Is it safe to remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2323 (comment)

xmudrii
xmudrii reviewed Nov 16, 2021
View reviewed changes
images/k8s-cloud-builder/variants.yaml
Comment on lines -14 to -19
cross1.15:
CONFIG: 'cross1.15'
KUBE_CROSS_VERSION: 'v1.15.15-1'
cross1.15-legacy:
CONFIG: 'cross1.15-legacy'
KUBE_CROSS_VERSION: 'v1.15.15-legacy-1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the other comment, since 1.20 is still not EOL, should we keep it around until 1.20 is not EOL?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2323 (comment)

@justaugustus
Copy link
Member Author

Isn't 1.15 still used by 1.20? Is it safe to remove this?
Similar to the other comment, since 1.20 is still not EOL, should we keep it around until 1.20 is not EOL?

@xmudrii -- For both instances, they are images that are based on EOL versions of Golang.
I think we could restore these variants if truly required, but I haven't yet seen instances where we've needed to rebuild these images over the last several months.

@justaugustus
Copy link
Member Author

(the bots didn't do all of the things they were supposed to, so:)
/retest-required
/kind cleanup
/area dependency
/assign @Verolop @xmudrii
cc: @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/dependency Issues or PRs related to dependency changes labels Nov 16, 2021
@justaugustus
Copy link
Member Author

(I expect several of the jobs to get stuck due to GCB quota, so let's be sure to give them a few minutes and then retest in batches.)

xmudrii
xmudrii approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [justaugustus,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 16, 2021
@justaugustus
Copy link
Member Author

/test pull-release-image-kube-cross

@justaugustus
Copy link
Member Author

/test pull-release-image-setcap

@justaugustus
Copy link
Member Author

/test pull-release-image-go-runner

@justaugustus
Copy link
Member Author

/test pull-release-image-debian-base
/test pull-release-image-k8s-ci-builder

@justaugustus
Copy link
Member Author

/test pull-release-image-k8s-cloud-builder
/test pull-release-image-releng-ci

@justaugustus
Copy link
Member Author

/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0fcb4c3 into kubernetes:master Nov 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@Verolop Verolop

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
4 participants
@justaugustus @k8s-ci-robot @xmudrii @Verolop