Minor improvements to krel promote-images #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/documentation
k8s-ci-robot
added
priority/important-soon
palnabarun
force-pushed
the
krel/promote-images
branch
from
7c307fa
to
5583534
Compare
When `krel promote-images` is called without passing a GitHub token, the error message didn't say what env var should be set. This commit adds the same to the error message. Signed-off-by: Nabarun Pal <[email protected]>
palnabarun
force-pushed
the
krel/promote-images
branch
from
5583534
to
f61457d
Compare
|
/test pull-release-verify |
k8s-ci-robot
added
size/M
palnabarun
changed the title
This will be helpful to verify the changes, if required to do so. Signed-off-by: Nabarun Pal <[email protected]>
palnabarun
force-pushed
the
krel/promote-images
branch
from
7f058d3
to
f032d32
Compare
k8s-ci-robot
added
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: palnabarun, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
When
krel promote-imagesis called without passing a GitHub token, theerror message didn't say what env var should be set. This commit adds
the same to the error message.
The promotion PR body now includes the command that was run to create the PR.
Which issue(s) this PR fixes:
Follow up on kubernetes/sig-release#1734
Special notes for your reviewer:
Does this PR introduce a user-facing change?
/cc @kubernetes/release-engineering
/area release-eng
/priority important-soon