Perform provenance verification in dedicated scratch dir #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modifies the provenance code to perform the artifact verification from stage in a dedicated scratch directory inside the Cloud Build workspace. Before, the scratch directory was created without control in the CWD resulting the bucket copy beign performed in the git tree. Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
cncf-cla: yes
saschagrunert
approved these changes
Oct 25, 2021
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR modifies the provenance code to perform the staged artifact verification in a dedicated scratch directory inside the Cloud Build workspace.
Before, the scratch directory was created without control in the current directory, resulting in the bucket copy being performed in the git tree.
Signed-off-by: Adolfo García Veytia (Puerco) [email protected]
Which issue(s) this PR fixes:
Part of: #2267
Follow-up to #2283
Special notes for your reviewer:
/assign @Verolop @justaugustus @cpanato
/cc @kubernetes/release-engineering
/priority important-soon
Does this PR introduce a user-facing change?