Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images: Build bullseye variants (part three) #2249

Merged
merged 6 commits into from
Sep 20, 2021

Conversation

justaugustus
Copy link
Member

@justaugustus justaugustus commented Sep 14, 2021

What type of PR is this?

/kind feature
/area dependency release-eng/security

What this PR does / why we need it:

Builds on top of #2210.
/hold for rebase magic

  • setcap: Build bullseye-v1.0.0 images
  • images: Build go1.17-bullseye variants (part two)
    • kube-cross:v1.23.0-go1.17.1-bullseye.0
    • k8s-ci-builder

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- setcap: Build bullseye-v1.0.0 images
- images: Build go1.17-bullseye variants (part two)
  - kube-cross:v1.23.0-go1.17.1-bullseye.0
  - k8s-ci-builder

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 14, 2021
@justaugustus justaugustus marked this pull request as ready for review September 14, 2021 23:20
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2021
@justaugustus
Copy link
Member Author

/hold cancel
(rebased out #2210)

Now to tackle those remaining test failures...

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2021
- kube-cross:v1.23.0-go1.17.1-bullseye.0
- k8s-ci-builder

Signed-off-by: Stephen Augustus <[email protected]>
Signed-off-by: Carlos Panato <[email protected]>
@cpanato
Copy link
Member

cpanato commented Sep 17, 2021

status of setcap, after the change now it is building

for buster

$ docker run -it gcr.io/k8s-staging-releng-test/setcap-amd64:buster-v2.0.4@sha256:97b4f9b36fff603b94ec25c72730424778c0f213b67fba250c121d42b6ba91a4 /bin/sh
Unable to find image 'gcr.io/k8s-staging-releng-test/setcap-amd64:buster-v2.0.4@sha256:97b4f9b36fff603b94ec25c72730424778c0f213b67fba250c121d42b6ba91a4' locally
gcr.io/k8s-staging-releng-test/setcap-amd64@sha256:97b4f9b36fff603b94ec25c72730424778c0f213b67fba250c121d42b6ba91a4: Pulling from k8s-staging-releng-test/setcap-amd64
1d4352b29680: Already exists
314598cfe48d: Pull complete
Digest: sha256:97b4f9b36fff603b94ec25c72730424778c0f213b67fba250c121d42b6ba91a4
Status: Downloaded newer image for gcr.io/k8s-staging-releng-test/setcap-amd64@sha256:97b4f9b36fff603b94ec25c72730424778c0f213b67fba250c121d42b6ba91a4
# . /etc/os-release; echo $VERSION_CODENAME
buster
# apt list --installed | grep libcap

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

libcap-ng0/oldstable,now 0.7.9-2 amd64 [installed,automatic]
libcap2-bin/oldstable,now 1:2.25-2 amd64 [installed]
libcap2/oldstable,now 1:2.25-2 amd64 [installed,automatic]

for bullseye

$ docker run -it gcr.io/k8s-staging-releng-test/setcap:bullseye-v1.0.0@sha256:dcba6973863cb70b28ef3b1d3a9833aac725de158fd583f4ff433d704a833d2c  /bin/sh
Unable to find image 'gcr.io/k8s-staging-releng-test/setcap:bullseye-v1.0.0@sha256:dcba6973863cb70b28ef3b1d3a9833aac725de158fd583f4ff433d704a833d2c' locally
gcr.io/k8s-staging-releng-test/setcap@sha256:dcba6973863cb70b28ef3b1d3a9833aac725de158fd583f4ff433d704a833d2c: Pulling from k8s-staging-releng-test/setcap
2252ee688176: Already exists
d8ffcf087777: Pull complete
Digest: sha256:dcba6973863cb70b28ef3b1d3a9833aac725de158fd583f4ff433d704a833d2c
Status: Downloaded newer image for gcr.io/k8s-staging-releng-test/setcap@sha256:dcba6973863cb70b28ef3b1d3a9833aac725de158fd583f4ff433d704a833d2c
# . /etc/os-release; echo $VERSION_CODENAME
bullseye
# apt list --installed | grep libcap

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

libcap-ng0/stable,now 0.7.9-2.2+b1 amd64 [installed,automatic]
libcap2-bin/stable,now 1:2.44-1 amd64 [installed]
libcap2/stable,now 1:2.44-1 amd64 [installed]

python-pip \
python3 \
python3-dev \
python3-pip \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any issues if you use python3? I guess the other it is deprecated already

@cpanato
Copy link
Member

cpanato commented Sep 18, 2021

/test pull-release-image-kube-cross

@cpanato
Copy link
Member

cpanato commented Sep 18, 2021

looks like there is a bug releated to the issue we are seeing here: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1924231

UPDATE: bump the multiarch/qemu-user-static

@cpanato
Copy link
Member

cpanato commented Sep 18, 2021

two issues now:
1: looks like some network issue

#11 [8/9] RUN go get golang.org/x/tools/cmd/cover            golang.org/x/tools/cmd/goimports     && go clean -cache
#11 11.20 go get: module golang.org/x/tools/cmd/cover: Get "https://proxy.golang.org/golang.org/x/tools/cmd/cover/@v/list": net/http: TLS handshake timeout
#11 11.21 go get: module golang.org/x/tools/cmd/goimports: Get "https://proxy.golang.org/golang.org/x/tools/cmd/goimports/@v/list": net/http: TLS handshake timeout
#11 ERROR: process "/bin/sh -c go get golang.org/x/tools/cmd/cover            golang.org/x/tools/cmd/goimports     && go clean -cache" did not complete successfully: exit code: 1
------
 > [8/9] RUN go get golang.org/x/tools/cmd/cover            golang.org/x/tools/cmd/goimports     && go clean -cache:
#11 11.20 go get: module golang.org/x/tools/cmd/cover: Get "https://proxy.golang.org/golang.org/x/tools/cmd/cover/@v/list": net/http: TLS handshake timeout
#11 11.21 go get: module golang.org/x/tools/cmd/goimports: Get "https://proxy.golang.org/golang.org/x/tools/cmd/goimports/@v/list": net/http: TLS handshake timeout
------

2: cloudbuild job timeout

5b463c23923b: Pushed
make: *** [Makefile:96: push] Terminated
1dd58fe4cd5a: Pushed
TIMEOUT

@cpanato
Copy link
Member

cpanato commented Sep 19, 2021

all green!

@justaugustus @puerco @Verolop

@cpanato
Copy link
Member

cpanato commented Sep 19, 2021

/hold to check if upgrade python is ok
/priority important-soon

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority labels Sep 19, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve
/hold cancel

@cpanato -- Updating python should be fine.
@kubernetes/release-engineering -- Needs /lgtm :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2021
Copy link
Member Author

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@cpanato -- Updating python should be fine.
@kubernetes/release-engineering -- Needs /lgtm :)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member Author

Thanks for working on this, Carlos! 💕

@puerco
Copy link
Member

puerco commented Sep 20, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 20, 2021
@k8s-ci-robot k8s-ci-robot merged commit db7f14c into kubernetes:master Sep 20, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 20, 2021
@justaugustus
Copy link
Member Author

Promotion PR: kubernetes/k8s.io#2763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants