Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[go] Build go1.17.1 and go1.16.8 images #2239

Merged
merged 1 commit into from
Sep 10, 2021
Merged

[go] Build go1.17.1 and go1.16.8 images #2239

merged 1 commit into from
Sep 10, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Sep 10, 2021

What type of PR is this?

/kind feature
/area dependency

What this PR does / why we need it:

[go] Build go1.17.1 and go1.16.8 images
tracking issue: #2238

/assign @justaugustus @puerco @xmudrii @Verolop @saschagrunert
/cc @kubernetes/release-engineering

Which issue(s) this PR fixes:

Special notes for your reviewer:

/hold for make sure all pass

Does this PR introduce a user-facing change?

[go] Build go1.17.1 and go1.16.8 images

@k8s-ci-robot k8s-ci-robot requested a review from a team September 10, 2021 08:29
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/dependency Issues or PRs related to dependency changes needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Sep 10, 2021
@cpanato cpanato mentioned this pull request Sep 10, 2021
Closed
26 tasks
@ameukam
Copy link
Member

ameukam commented Sep 10, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2021
@cpanato
Copy link
Member Author

cpanato commented Sep 10, 2021

/test pull-release-image-go-runner

justaugustus
justaugustus approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 962f405 into kubernetes:master Sep 10, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.23 milestone Sep 10, 2021
@cpanato cpanato deleted the GH-2238-images branch September 10, 2021 11:51
@cpanato
Copy link
Member Author

cpanato commented Sep 10, 2021

will continue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus justaugustus approved these changes

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@Verolop Verolop

@ameukam ameukam

@puerco puerco

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.23
Development

Successfully merging this pull request may close these issues.
8 participants
@cpanato @ameukam @k8s-ci-robot @justaugustus @saschagrunert @Verolop @puerco @xmudrii