-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to build custom Kubernetes forks #2074
Conversation
599bfc3
to
a018f48
Compare
Testing with kubernetes/kubernetes#102126 and kubernetes/kubernetes#102125:
|
We could think about making those variables real flags in krel, which would allow us adding some documentation as well as use cases around them. |
Ready for some first thoughts 🙃 |
I wanted to hook up during the week to talk about this but I was buried in work. It looks good to me obviously, but I'm curious about the use case. HOw are you planning to use it? 🤔 |
Same question as Adolfo! |
The use case would be, that if I change a code part in k/k which affects the way how we build releases, then I'm now able to verify those changes by staging a custom release from my fork. Another (future) use case could be, that as a maintainer of a custom k/k fork, I'm now able to cut releases within community infra. This is a different discussion where we have to decide if we wanna go that far, but in theory it would be possible. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@saschagrunert: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
@saschagrunert -- Can you rebase? |
a018f48
to
546b63c
Compare
Signed-off-by: Sascha Grunert <[email protected]>
546b63c
to
c07cf98
Compare
Rebased and tested manually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome. Thanks @saschagrunert!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justaugustus, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This patch adds the possibility to use the environment variables
K8S_ORG
,K8S_REPO
andK8S_REF
to specify a custom Kubernetes fork for building releases. It is not possible right now tokrel release
them. But staging for testing and artifact discovery is a common use cases when changing the build infra in k/k.Which issue(s) this PR fixes:
Fixes #1883
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?