k8s-ci-builder/releng-ci/kubepkg: add a REGISTRY substitution to allow registry selection #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
kind/feature
k8s-ci-robot
added
area/release-eng
cpanato
changed the title
k8s-ci-robot
added
size/S
cpanato
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
cpanato
changed the title
cpanato
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
I think one thing we can do to avoid this, will check the image-builder service. |
|
/test pull-release-image-releng-ci |
|
/test pull-release-image-k8s-ci-builder |
|
checked the images and all have being built /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
same work we did for kube-cross: #1943 we are applying for
k8s-ci-builderandreleng-ciandkubepkgk/test-infra PR to update the jobs: TBC
/assign @justaugustus @saschagrunert @hasheddan
tracking issue: #1850
/hold for the test-infra job update
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?