-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cross: create new variant with protobuf version 3.0.2 #1915
Conversation
4655198
to
2d22ad3
Compare
@cpanato: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
@justaugustus PTAL when having a chance |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Create another kube-cross variant using go 1.15.8 and the old protobuf version (3.0.2)
the protobuf was bumped in this PR to add support for arm64 however it needs some update in the k/k generated files.
For the existing release branches (1.20/1.19) we want to avoid the update of the generated files to reduce a possible introduction of issues (for reference: kubernetes/kubernetes#98962 (review))
/assign @dims @justaugustus
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?