Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross: create new variant with protobuf version 3.0.2 #1915

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 15, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

Create another kube-cross variant using go 1.15.8 and the old protobuf version (3.0.2)

the protobuf was bumped in this PR to add support for arm64 however it needs some update in the k/k generated files.

For the existing release branches (1.20/1.19) we want to avoid the update of the generated files to reduce a possible introduction of issues (for reference: kubernetes/kubernetes#98962 (review))

/assign @dims @justaugustus

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

cross: create new variant with protobuf version 3.0.2

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2021
@cpanato cpanato changed the title cross: create new variant with protobuf version 3.0.2 WIP cross: create new variant with protobuf version 3.0.2 Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 15, 2021
@cpanato cpanato changed the title WIP cross: create new variant with protobuf version 3.0.2 cross: create new variant with protobuf version 3.0.2 Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 15, 2021
@cpanato cpanato force-pushed the protobuf branch 3 times, most recently from 4655198 to 2d22ad3 Compare February 15, 2021 17:04
@k8s-ci-robot
Copy link
Contributor

@cpanato: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-release-image-kube-cross 2d22ad3 link /test pull-release-image-kube-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2021
@cpanato
Copy link
Member Author

cpanato commented Feb 15, 2021

@justaugustus PTAL when having a chance

@justaugustus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3262293 into kubernetes:master Feb 15, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 15, 2021
@cpanato cpanato deleted the protobuf branch February 15, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants