Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verify-build step to make target #1863

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Add verify-build step to make target #1863

merged 1 commit into from
Jan 21, 2021

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 21, 2021 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This new targets builds the project for a couple of chosen platforms,
which should hint us in the future if any dependency may not work for
one of those.

Which issue(s) this PR fixes:

Refers to #1862

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 21, 2021
@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 21, 2021
@saschagrunert
Copy link
Member Author

saschagrunert commented Jan 21, 2021 •
edited
Loading

pull-release-verify tells us that it works:

…
Building project for linux/386
Building project for linux/arm
Building project for linux/arm64
Building project for linux/ppc64le
Building project for linux/s390x
Building project for windows/amd64
go: downloading github.com/inconshreveable/mousetrap v1.0.0
go: downloading github.com/Azure/go-ansiterm v0.0.0-20170929234023-d6e3b3328b78
go: downloading github.com/StackExchange/wmi v0.0.0-20190523213315-cbe66965904d
go: downloading github.com/go-ole/go-ole v1.2.4
Building project for windows/386
Building project for freebsd/amd64
Building project for darwin/amd64
…

The job now takes a bit longer, as expected.

@xmudrii
Copy link
Member

xmudrii commented Jan 21, 2021

It doesn't take longer than pull-release-cluster-up, so I don't think it matters that it runs a little bit longer. :)

xmudrii
xmudrii reviewed Jan 21, 2021
View reviewed changes
Makefile Show resolved Hide resolved
@saschagrunert
Add verify-build step to make target
4be32f1 
This new targets builds the project for a couple of chosen platforms,
which should hint us in the future if any dependency may not work for
one of those.

Signed-off-by: Sascha Grunert <[email protected]>
xmudrii
xmudrii approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [saschagrunert,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f680678 into kubernetes:master Jan 21, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 21, 2021
@saschagrunert saschagrunert deleted the verify-build branch January 21, 2021 11:30
@roee88 roee88 mentioned this pull request Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@hasheddan hasheddan Awaiting requested review from hasheddan

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
3 participants
@saschagrunert @xmudrii @k8s-ci-robot