Add CreatePullRequest() to github pkg and clients #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
puerco
force-pushed
the
github-createpr
branch
5 times, most recently
from
dffcaa8
to
3972f06
Compare
saschagrunert
approved these changes
May 8, 2020
|
|
||
| pr, _, err := g.PullRequests.Create(ctx, owner, repo, newPullRequest) | ||
| if err != nil { | ||
| return pr, err |
There was a problem hiding this comment.
nit, to add more context to the error messages:
Suggested change
| return pr, err | |
| return pr, errors.Wrap(err, "creating pull request") |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Relates to #834 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR enables creating Pull Requests in a GItHub repository from the github pkg. It adds a
CreatePullRequest()func and its corresponding implementation ingithub.Client. It also adds noop functions in the replay and record packages to keep them compatible with the Client interface. Finally it adds some basic testing.Which issue(s) this PR fixes:
Special notes for your reviewer:
I've split the PR in two commits:
CreatePullRequest()func to the interface and the clients (the real one, fake, replay and record).CreatePullRequest()function to the github package and it's corresponding tests inTestCreatePullRequest().Does this PR introduce a user-facing change?