release notes generator does not pick up edits to PRs

[tpepper]

release-notify for 1.15.2, 1.14.5, and 1.13.9 did not pick up the edited PRs release note content after the embargo was lifted and we were publishing info on the releases. This feels like a fairly normal workflow. The notes do come via the GitHub API. Probably additional code is needed to handle pulling a release note stanza from a stack of edited PR descriptions?

[tpepper]

/sig release
/area release-eng

@kubernetes/patch-release-team

[saschagrunert]

Hey @tpepper, may I ask you for a reproducer of this? I had a look into the generator sources and it seems to pick always the latest PR version via the GitHub API. The internal de-duplication cache works based on the text (the content) of the note, so this should not fail as well.

[saschagrunert]

Might be fixed with #902

[idealhack]

note: this happened for pre-release notifications (https://github.com/kubernetes/release/blob/master/relnotes) in Nov. https://kubernetes.slack.com/archives/CJH2GBF7Y/p1573233887162900

[saschagrunert]

I suggest to continue there #918 due to the fact that we want to replace the script with the golang based version.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[saschagrunert]

This should be fixed when using krel changelog for patch releases (not yet implemented)

/remove-lifecycle stale

[saschagrunert]

@hoegaarden do you think we are ready to merge the code paths for patch release announcements and minor releases?

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[saschagrunert]

This should be fixed, the old release notes scripts do not exist any more on the master branch.

/close

[k8s-ci-robot]

@saschagrunert: Closing this issue.

In response to this:

This should be fixed, the old release notes scripts do not exist any more on the master branch.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.