bsdmainutils requirement limits gcbmgr to debian distros

[tpepper]

In pull request #667

commit e7685c51783afc6577bac7cb787c9e5a783c159a
Author: Hannes Hörl <[email protected]>
Date:   Mon Feb 25 09:17:29 2019 +0000

    Make sure essential packages are installed

adds "bsdmainutils" package to the gcbmgr package check list. Lacking this package installed on Fedora, the following is displayed:

Checking required system packages: FAILED
PREREQ: Missing prerequisites: bsdmainutils Run the following and try again:

$ sudo dnf install bsdmainutils

Exiting...

That does not work as there is no bsdmainutils package in the Fedora ecosystem.

Debian info for the package indicates quite a number of utilities:

It provides banner (as printerbanner), calendar, col, colcrt, colrm, column, from (as bsd-from), hexdump (or hd), look, lorder, ncal (or cal), ul, and write (as bsd-write).

These come from a variety of locations in Fedora.

[tpepper]

I'm guessing it was pulled in for 'column', which Fedora gets via util-linux.

[justaugustus]

/milestone v1.15
/priority important-soon
/area release-eng

[pswica]

What would you think of changing common::check_packages to something like:

for prereq in $*; do
    command -v $PREREQ > /dev/null 2>&1 || missing+=($prereq)
done

if ((${#missing[@]}>0)); then
    logecho -r "$FAILED"
    logecho "PREREQ: Missing prerequisites: ${missing[@]}"
    return 1
fi

Where the prerequisites are binaries rather than packages. This way, when distributions differ on package management there's no need to update the script. I assume that whoever is using the script can figure out how to install the required bins.

I'm a bit new to contributing to open source, and this repo, so apologies if I'm making assumptions. Let me know if you think this is good idea and I can try a PR.

[pswica]

@hoegaarden
My PR above should have resolved this. Let me know if it's good to close

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[idealhack]

/remove-lifecycle stale

since the change of linked PR got reverted later after its merge.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.