Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[krel] Allow krel to interpret an arbitrary k/release git reference instead of just branches (TOOL_BRANCH) #1028

Closed
justaugustus opened this issue Jan 19, 2020 · 12 comments · Fixed by #1906
Assignees
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Milestone

Comments

@justaugustus
Copy link
Member

justaugustus commented Jan 19, 2020

While debugging kubernetes/kubernetes#86182 and #1020, we ran a few mock stages and releases targeting anago against forks of k/release.

I noticed that it might've been nice to have more information available which fork and commit we were using at any one time, so a few suggestions:

  • Allow krel to interpret a git ref (instead of just branch) for use as the release tools repo to checkout (changes to both krel and the gcb/{stage,release} configs)
    - Surface the release tool repo org, name, branch (if chosen), and git ref at the time of run as part of the anago session values

@tpepper -- Thoughts?

/help
/milestone v1.18
/sig release
/area release-eng
/priority important-soon

@k8s-ci-robot
Copy link
Contributor

@justaugustus:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

While debugging kubernetes/kubernetes#86182 and #1020, we ran a few mock stages and releases targeting anago against forks of k/release.

I noticed that it might've been nice to have more information available which fork and commit we were using at any one time, so a few suggestions:

  • Allow anago to interpret a git ref (instead of just branch) for use as the release tools repo to checkout (changes to both anago and the gcb/{stage,release} configs)
  • Surface the release tool repo org, name, branch (if chosen), and git ref at the time of run as part of the anago session values

@tpepper -- Thoughts?

/help
/milestone v1.18
/sig release
/area release-eng
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 19, 2020
@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 19, 2020
@justaugustus justaugustus added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 19, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 18, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 18, 2020
@justaugustus
Copy link
Member Author

Let's consider this an eventual feature request for krel anago, not the shell-based tool.
/remove-lifecycle rotten
/milestone clear

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 21, 2020
@k8s-ci-robot k8s-ci-robot removed this from the v1.18 milestone May 21, 2020
@tpepper
Copy link
Member

tpepper commented Jul 27, 2020

This could be emitting more info like git status and cat .git/config at anago runtime.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2020
@markjacksonfishing
Copy link

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 25, 2020
@saschagrunert
Copy link
Member

@justaugustus is this something we still need? We drastically changed the logging approach in krel stage/release. For example the --log-level=debug output will implicitly increase the git verbosity output, too.

@justaugustus
Copy link
Member Author

@saschagrunert -- I think this might still be useful:

Allow anago to interpret a git ref (instead of just branch) for use as the release tools repo to checkout (changes to both anago and the gcb/{stage,release} configs)

s/anago/krel

AND

s/TOOL_BRANCH/TOOL_REF

thoughts?

@saschagrunert
Copy link
Member

thoughts?

Yes, this seems straight forward to implement.

@justaugustus justaugustus changed the title [anago] Potential improvements for logging k/release repo information [krel] Allow krel to interpret an arbitrary k/release git reference instead of just branches (TOOL_BRANCH) Dec 3, 2020
@justaugustus
Copy link
Member Author

updated the issue title

@cpanato
Copy link
Member

cpanato commented Feb 5, 2021

/assign

k8s-ci-robot added a commit that referenced this issue Mar 22, 2021
move references from TOOL_BRANCH to be TOOL_REF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants