-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redirect AWS client blob requests to s3 based on client IP -> AWS region #47
Conversation
6dcd21b
to
9436135
Compare
moved some of this to #48 |
tests still need work, will get back to this in the morning. |
I'll have some more unit tests / cleanup committed later this morning and then this should be ready for reviews. |
Probably should feature-gate this in some fashion, but it's otherwise done. |
I think we can do that in a follow-up, this is pretty large as-is. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
builds on #42, depends on #46
~fixes #39
Implements:
Also clarifies that cmd/archeio is not engineered to be reusable at this time, instead the reusable bits are implemented as library packages (like the CIDR matching, IP to AWS region matching).
We can greatly simplify runtime concerns and reliability by keeping it this way for now.
In the future it's possible we'll be using an entirely different approach (CDN?) anyhow.
Needs cleanup, tests, and a feature gate of some sort (disabled by default, we're not ready to roll this out yet), but it's there.
Right now all regions are mapped to the single bucket we have.
We can use that to test in CI in the sandbox, but before enabling in production we will need to replace with our real bucket mapping.