add e2e tests in addition to cluster e2e testing #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we already need it for geranos and for archeio test code, we don't need to track it as a binary seperately.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
BenTheElder
commented
Apr 7, 2023
| } | ||
| } | ||
|
|
||
| // common helper for executing test pull and checking output |
There was a problem hiding this comment.
I have more WIP code to test other clients, which is why this is broken out already.
Will follow up with that shortly, but I want to get the CI jobs and base concept in place first.
while we should avoid "tainted" subprocess exec in prod, this is fine in test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to quickly test the staging instance.
After this PR we'll automatically test some quick and cheap e2e tests immediately following staging deploys.
See code comments for why these are different from the integration tests.
This PR also cleans up tracking crane versions in two places
TODO:
make e2e-test-local(e2e tests against a local instance, for testing the tests) add registry e2e tests test-infra#29249make e2e-testand add that to the docs add registry e2e tests test-infra#29249 for GCP add registry e2e job on AWS test-infra#29251 for AWS