Add new repositories for component config and cli #97
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dims If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
| @@ -846,3 +846,79 @@ data: | |||
| branch: release-1.12 | |||
| - repository: client-go | |||
| branch: release-9.0 | |||
| - destination: sample-cli-plugin | |||
| library: true | |||
There was a problem hiding this comment.
is this a library? I.e. do we want complete Godeps? For libraries we remove some of the k8s.io dependencies to be go-gettable. Ugly but necessary.
There was a problem hiding this comment.
After looking into the staging repo, this is most certainly not a library, but a command only.
There was a problem hiding this comment.
so i change this to library: false?
| dir: staging/src/k8s.io/kube-proxy | ||
| name: master | ||
| dependencies: | ||
| - repository: apimachinery |
There was a problem hiding this comment.
nvmd. With the config apis only right, porbably it is complete
There was a problem hiding this comment.
yep, listed only those in GoDeps
| dependencies: | ||
| - repository: apimachinery | ||
| branch: master | ||
| - repository: api |
There was a problem hiding this comment.
nvmd. With the config apis only right, porbably it is complete
dims
force-pushed
the
add-repositories-for-component-config-and-cli
branch
from
d4a1a94 to
55d964e
Compare
| branch: master | ||
| - repository: client-go | ||
| branch: master | ||
| - destination: cli-runtime |
There was a problem hiding this comment.
order is wrong: it must be in topological order, i.e. depending repos after dependencies.
New repos requested in: kubernetes/org#58 kubernetes/org#56 Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13
dims
force-pushed
the
add-repositories-for-component-config-and-cli
branch
from
55d964e to
0061b95
Compare
|
Repos have been published. 🎉 Closing as the follow-up PR has been merged. |
New repos requested in:
kubernetes/org#58
kubernetes/org#56
Change-Id: I2e71a998db2e53b8d8827a59a7b35198f52e3e13