Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] setup publishing bot for containerd #310

Closed
wants to merge 2 commits into from
Closed

[WIP] setup publishing bot for containerd #310

wants to merge 2 commits into from

Conversation

akhilerm
Copy link
Member

@akhilerm akhilerm commented Feb 13, 2023 •
edited
Loading

  • install git-filter-repo
  • update base image to bullseye for installing filter-repo via backports
  • change master to main
  • add support for multiple directories
  • change filter branch with filter repo
  • enable support for branches with "/" in branch name

Signed-off-by: Akhil Mohan [email protected]

EDIT: This PR will be split into multiple small changes so that it can be merged into the master branch.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akhilerm
Once this PR has been reviewed and has the lgtm label, please assign jeremyrickard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from jrsapi February 13, 2023 11:07
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 13, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2023
@akhilerm
setup publishing bot for containerd
b60bbb4 
- install git-filter-repo
- update base image to bullseye for installing filter-repo via
backports
- change master to main
- add support for multiple directories
- change filter branch with filter repo
- enable support for branches with "/" in branch name

Signed-off-by: Akhil Mohan <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2023
palnabarun
palnabarun reviewed Feb 24, 2023
View reviewed changes
Dockerfile
Comment on lines -15 to +21
FROM debian:stretch
FROM debian:bullseye
MAINTAINER Stefan Schimanski <[email protected]>
RUN echo deb http://deb.debian.org/debian bullseye-backports main >> /etc/apt/sources.list
RUN apt-get update \
&& apt-get install -y -qq git=1:2.11.0-3+deb9u7 \
&& apt-get install -y -qq git \
&& apt-get install -y -qq mercurial \
&& apt-get install -y -qq ca-certificates curl wget jq vim tmux bsdmainutils tig gcc zip \
&& apt-get install -y -qq ca-certificates curl wget jq vim tmux bsdmainutils tig gcc zip git-filter-repo/bullseye-backports \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be in a separate commit.

Also, there might be some history as to why git is pinned to that version. That needs to be investigated before unpinning the version.

artifacts/scripts/construct.sh
Comment on lines -150 to +152
--push-script ${PUSH_SCRIPT} \
--push-script ${PUSH_SCRIPT} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unintended indentation change?

nikhita
nikhita reviewed Feb 24, 2023
View reviewed changes
artifacts/scripts/construct.sh
@@ -45,9 +45,9 @@ fi
# the target repo
REPO="${1}"
# src branch of k8s.io/kubernetes
SRC_BRANCH="${2:-master}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kubernetes still uses master so we'll need to be able to configure this

@akhilerm
Copy link
Member Author

This PR will be split into multiple small changes so that it can be merged into the master branch. The list of changes include

  • making the main branch name configurable,
  • adding support for multiple directories in the rules section
  • switching to filter-repo for filtering the commits
  • handling go mod related changes

@nikhita nikhita mentioned this pull request Feb 24, 2023
Closed
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2023
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2024
@akhilerm
Copy link
Member Author

/close
changes are carried in #369

@k8s-ci-robot
Copy link
Contributor

@akhilerm: Closed this PR.

In response to this:

/close
changes are carried in #369

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhita nikhita nikhita left review comments

@palnabarun palnabarun palnabarun left review comments

@jimangel jimangel Awaiting requested review from jimangel

@jrsapi jrsapi Awaiting requested review from jrsapi

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@akhilerm @k8s-ci-robot @k8s-triage-robot @palnabarun @nikhita